Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-11723: [Rust][DataFusion] Change SQL parser to use PostgreSQL dialect #9541

Closed
wants to merge 1 commit into from

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Feb 21, 2021

As suggested by @andygrove we should use the PostgreSQL dialect now (by default), now that we decided o be PostgreSQL-compatible.

Currently this makes the VarProvider fail (introduced here: #8135), which depends on identifiers starting with @, and which is not supported in PostgreSQL. I am wondering if we should remove this feature or make it work in another way?

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@Dandandan Dandandan changed the title [Rust][DataFusion] Change SQL parser to use PostgreSQL dialect ARROW-11723: [Rust][DataFusion] Change SQL parser to use PostgreSQL dialect Feb 21, 2021
@github-actions
Copy link

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be worth updating the README or other documentation as well

@alamb
Copy link
Contributor

alamb commented Apr 19, 2021

The Apache Arrow Rust community is moving the Rust implementation into its own dedicated github repositories arrow-rs and arrow-datafusion. It is likely we will not merge this PR into this repository

Please see the mailing-list thread for more details

We expect the process to take a few days and will follow up with a migration plan for the in-flight PRs.

@alamb
Copy link
Contributor

alamb commented May 3, 2021

#10096 has removed the arrow implementation from this repository (it now resides in https://github.com/apache/arrow-rs and https://github.com/apache/arrow-datafusion) in the hopes of streamlining the development process

Please re-target this PR (let us know if you need help doing so) to one/both of the new repositories.

Thank you for understanding and helping to make arrow-rs and datafusion better

@alamb alamb closed this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants