Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44980: [CI] Remove retrieval of Arrow version from Java on Spark integration and update test structure for PySpark #44981

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Dec 9, 2024

Rationale for this change

The job is currently failing.

What changes are included in this PR?

Remove unnecessary check on Java code and refactor pyspark test modules to follow new test structure: apache/spark#49104

Are these changes tested?

Via archery

Are there any user-facing changes?

No

Copy link

github-actions bot commented Dec 9, 2024

⚠️ GitHub issue #44980 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 9, 2024
@raulcd
Copy link
Member Author

raulcd commented Dec 9, 2024

@github-actions crossbow submit test--spark-

Copy link

github-actions bot commented Dec 9, 2024

Revision: c410de9

Submitted crossbow builds: ursacomputing/crossbow @ actions-5eb2ac471e

Task Status
test-conda-python-3.11-spark-master GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Dec 9, 2024

Tests seem to be failing but this failure is not related to the original issue:

 Starting test(python): pyspark.sql.tests.test_arrow (temp output: /spark/python/target/71d33db2-ca30-4e89-8edf-6aed57761990/python__pyspark.sql.tests.test_arrow__kzeeud_w.log)
/opt/conda/envs/arrow/bin/python: No module named pyspark.sql.tests.test_arrow

Had test failures in pyspark.sql.tests.test_arrow with python; see logs.

@raulcd
Copy link
Member Author

raulcd commented Dec 9, 2024

@github-actions crossbow submit test--spark-

Copy link

github-actions bot commented Dec 9, 2024

Revision: 3deeecd

Submitted crossbow builds: ursacomputing/crossbow @ actions-ab6d626f46

Task Status
test-conda-python-3.11-spark-master GitHub Actions

@raulcd raulcd changed the title GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration GH-44980: [CI] Remove retrieval of arrow version from Java on Spark integration and update test structure for pyspark Dec 9, 2024
@raulcd
Copy link
Member Author

raulcd commented Dec 9, 2024

@github-actions crossbow submit test-conda-python-3.11-spark-master

Copy link

github-actions bot commented Dec 9, 2024

Revision: 084399a

Submitted crossbow builds: ursacomputing/crossbow @ actions-f1ce0ab770

Task Status
test-conda-python-3.11-spark-master GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Dec 9, 2024

@github-actions crossbow submit test-conda-python-3.11-spark-master

Copy link

github-actions bot commented Dec 9, 2024

Revision: e661dea

Submitted crossbow builds: ursacomputing/crossbow @ actions-7f74565d52

Task Status
test-conda-python-3.11-spark-master GitHub Actions

@raulcd raulcd marked this pull request as ready for review December 9, 2024 22:33
@kou kou changed the title GH-44980: [CI] Remove retrieval of arrow version from Java on Spark integration and update test structure for pyspark GH-44980: [CI] Remove retrieval of Arrow version from Java on Spark integration and update test structure for PySpark Dec 10, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment on lines +45 to +46
# "pyspark.sql.tests.arrow.test_arrow_grouped_map" and
# "pyspark.sql.tests.arrow.test_arrow_cogrouped_map" currently fail.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they known issues? If so, could you add an issue number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment with the issue: #44986
As shared on the new issue those tests were never run in the past but might be worth adding them as they are arrow related.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Dec 10, 2024
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Merging this to fix the spark integration failures,.

@raulcd raulcd merged commit 5db2843 into apache:main Dec 11, 2024
14 of 15 checks passed
@raulcd raulcd removed the awaiting changes Awaiting changes label Dec 11, 2024
@raulcd raulcd deleted the GH-44980 branch December 11, 2024 09:24
Copy link

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 5db2843.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants