-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44980: [CI] Remove retrieval of Arrow version from Java on Spark integration and update test structure for PySpark #44981
Conversation
…om Java on Spark integration
|
@github-actions crossbow submit test--spark- |
Revision: c410de9 Submitted crossbow builds: ursacomputing/crossbow @ actions-5eb2ac471e
|
Tests seem to be failing but this failure is not related to the original issue:
|
@github-actions crossbow submit test--spark- |
Revision: 3deeecd Submitted crossbow builds: ursacomputing/crossbow @ actions-ab6d626f46
|
@github-actions crossbow submit test-conda-python-3.11-spark-master |
Revision: 084399a Submitted crossbow builds: ursacomputing/crossbow @ actions-f1ce0ab770
|
@github-actions crossbow submit test-conda-python-3.11-spark-master |
Revision: e661dea Submitted crossbow builds: ursacomputing/crossbow @ actions-7f74565d52
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
# "pyspark.sql.tests.arrow.test_arrow_grouped_map" and | ||
# "pyspark.sql.tests.arrow.test_arrow_cogrouped_map" currently fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they known issues? If so, could you add an issue number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment with the issue: #44986
As shared on the new issue those tests were never run in the past but might be worth adding them as they are arrow related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merging this to fix the spark integration failures,.
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 5db2843. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
The job is currently failing.
What changes are included in this PR?
Remove unnecessary check on Java code and refactor pyspark test modules to follow new test structure: apache/spark#49104
Are these changes tested?
Via archery
Are there any user-facing changes?
No