Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50517][PYTHON][TESTS] Group arrow function related tests #49104

Closed

Conversation

zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Dec 7, 2024

What changes were proposed in this pull request?

Group arrow function related tests

Why are the changes needed?

test clean up

Does this PR introduce any user-facing change?

no, test only

How was this patch tested?

ci

Was this patch authored or co-authored using generative AI tooling?

no

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, @zhengruifeng and @HyukjinKwon .

According to the content, this is more arrow-related tests instead of pandas related tests. Did I understand correctly?

I'm curious about the relation between this and the previous pandas PR (the following).

@zhengruifeng zhengruifeng changed the title [SPARK-50517][PYTHON][TESTS] Group pandas function related tests [SPARK-50517][PYTHON][TESTS] Group arrow function related tests Dec 9, 2024
@zhengruifeng
Copy link
Contributor Author

Ur, @zhengruifeng and @HyukjinKwon .

According to the content, this is more arrow-related tests instead of pandas related tests. Did I understand correctly?

I'm curious about the relation between this and the previous pandas PR (the following).

Thanks for the reminder, you are right they are for arrow

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you for updating.
Merged to master.

@zhengruifeng zhengruifeng deleted the group_connect_test_arrow branch December 10, 2024 01:08
HyukjinKwon added a commit that referenced this pull request Dec 11, 2024
…ure Python test

### What changes were proposed in this pull request?

This PR is a followup of #49104 that adds refactored package into pure Python test

### Why are the changes needed?

In order to fix the pure Python build https://github.com/apache/spark/actions/runs/12262937305/job/34213372670

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

Will monitor the build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49137 from HyukjinKwon/SPARK-50517-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
raulcd added a commit to apache/arrow that referenced this pull request Dec 11, 2024
…ntegration and update test structure for PySpark (#44981)

### Rationale for this change

The job is currently failing.

### What changes are included in this PR?

Remove unnecessary check on Java code and refactor pyspark test modules to follow new test structure: apache/spark#49104

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No
* GitHub Issue: #44980

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
HyukjinKwon added a commit that referenced this pull request Dec 12, 2024
…ure Python test

### What changes were proposed in this pull request?

This PR is a followup of #49104 that adds refactored package into pure Python test

### Why are the changes needed?

In order to fix the pure Python build https://github.com/apache/spark/actions/runs/12283159330/job/34275992419

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

Will monitor the build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49158 from HyukjinKwon/SPARK-50517-followup2.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants