Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failing Test]: MLTransform IT test is failing #30191

Closed
1 of 16 tasks
tvalentyn opened this issue Feb 1, 2024 · 6 comments · Fixed by #30202
Closed
1 of 16 tasks

[Failing Test]: MLTransform IT test is failing #30191

tvalentyn opened this issue Feb 1, 2024 · 6 comments · Fixed by #30202
Assignees
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. failing test P1 permared python tests

Comments

@tvalentyn
Copy link
Contributor

What happened?

apache_beam/examples/ml_transform/ml_transform_it_test.py::LargeMovieReviewDatasetProcessTest::test_process_large_movie_review_dataset is perma-failing:

FileNotFoundError: [Errno 2] No such file or directory: 'gs://temp-storage-for-end-to-end-tests/tft/8825e9c2853143f289c2673feb3bc64b'

Sample run: https://github.com/apache/beam/actions/runs/7732452652/job/21082406012#step:29:2783

cc: @AnandInguva

Issue Failure

Failure: Test is continually failing

Issue Priority

Priority: 1 (unhealthy code / failing or flaky postcommit so we cannot be sure the product is healthy)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@tvalentyn tvalentyn changed the title [Failing Test]: MLTransform IT [Failing Test]: MLTransform IT test is faling Feb 1, 2024
@tvalentyn
Copy link
Contributor Author

gsutil ls gs://temp-storage-for-end-to-end-tests/tft/8825e9c2853143f289c2673feb3bc64b
gs://temp-storage-for-end-to-end-tests/tft/8825e9c2853143f289c2673feb3bc64b/attributes.json
gs://temp-storage-for-end-to-end-tests/tft/8825e9c2853143f289c2673feb3bc64b/c4f900/

@tvalentyn
Copy link
Contributor Author

interestingly, files are there, so maybe it's a permission issue?

@tvalentyn
Copy link
Contributor Author

Repro:

pip install tensorflow-transform apache-beam
from apache_beam.ml.transforms.utils import ArtifactsFetcher
artifact_location='gs://temp-storage-for-end-to-end-tests/tft/8825e9c2853143f289c2673feb3bc64b'
artifacts_fetcher = ArtifactsFetcher(artifact_location=artifact_location)
actual_vocab_list = artifacts_fetcher.get_vocab_list()

FileNotFoundError: [Errno 2] No such file or directory: 'gs://temp-storage-for-end-to-end-tests/tft/8825e9c2853143f289c2673feb3bc64b'

@tvalentyn
Copy link
Contributor Author

Probably failing after #29564.

We should use Beam FileSystem in these cases:

files = os.listdir(artifact_location)

@tvalentyn
Copy link
Contributor Author

It might be a regression in the currently cut release.

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Feb 1, 2024

Actually, not a regression in 2.54.0 since #30191 was already in 2.53.0-RC1. But I think it limits usability of MLTransform.

@tvalentyn tvalentyn changed the title [Failing Test]: MLTransform IT test is faling [Failing Test]: MLTransform IT test is failing Feb 1, 2024
@tvalentyn tvalentyn removed this from the 2.54.0 Release milestone Feb 2, 2024
@github-actions github-actions bot added this to the 2.55.0 Release milestone Feb 9, 2024
@damccorm damccorm added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. failing test P1 permared python tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants