Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artifacts fetcher to download artifacts locally using FileSystems #30202

Merged
merged 10 commits into from
Feb 9, 2024

Conversation

AnandInguva
Copy link
Contributor

fixes: #30191


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva
Copy link
Contributor Author

converting this to draft.

@AnandInguva AnandInguva marked this pull request as draft February 2, 2024 23:17
@github-actions github-actions bot added examples and removed examples labels Feb 6, 2024
@AnandInguva
Copy link
Contributor Author

@AnandInguva
Copy link
Contributor Author

@github-actions github-actions bot added examples and removed examples labels Feb 7, 2024
@AnandInguva
Copy link
Contributor Author

AnandInguva commented Feb 7, 2024

@AnandInguva
Copy link
Contributor Author

R: @tvalentyn

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AnandInguva AnandInguva marked this pull request as ready for review February 7, 2024 20:59
Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! PTAL at lint errors.

sdks/python/apache_beam/ml/transforms/utils.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/transforms/utils.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/transforms/utils.py Outdated Show resolved Hide resolved
@AnandInguva AnandInguva merged commit aefcada into master Feb 9, 2024
71 checks passed
@AnandInguva AnandInguva deleted the fix-path branch February 9, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: MLTransform IT test is failing
2 participants