-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14436] Adds code reviewers for GCP I/O connectors and KafkaIO to Beam OWNERS files #17581
Conversation
R: @aaltay |
Codecov Report
@@ Coverage Diff @@
## master #17581 +/- ##
==========================================
+ Coverage 73.85% 73.93% +0.08%
==========================================
Files 690 691 +1
Lines 91227 91562 +335
==========================================
+ Hits 67373 67698 +325
- Misses 22621 22631 +10
Partials 1233 1233
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ecc7a11
to
86a8833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Run Python PreCommit |
Run Spotless PreCommit |
spotless failure may not be a flake, could you check that and self merge after that? |
Thanks! |
Run Spotless PreCommit |
88fcddb
to
9f09edc
Compare
Also updates the connector code to suggest using these reviewers for any significant changes to these connectors.
This will help reduce future regressions related to these connectors.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.