Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14436] Adds code reviewers for GCP I/O connectors and KafkaIO to Beam OWNERS files #17581

Merged
merged 1 commit into from
May 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdks/java/extensions/google-cloud-platform-core/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@
reviewers:
- lukecwik
- chamikaramj
- pabloem
- ihji
- johnjcasey
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,16 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/** {@link FileSystem} implementation for Google Cloud Storage. */
/**
* {@link FileSystem} implementation for Google Cloud Storage.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/OWNERS">
* here</a>.
*/
@SuppressWarnings({
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
})
Expand Down
33 changes: 32 additions & 1 deletion sdks/java/io/google-cloud-platform/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,36 @@
# See the OWNERS docs at https://s.apache.org/beam-owners

reviewers:
reviewers (BigTableIO) :
- igorbernstein2

reviewers (SpannerIO) :
- darshan-sj
- nielm

reviewers (SpannerIO - readChangeStream) :
- cl2012
- nancyxu123
- haikuo-google

reviewers (BigQueryIO - Storage Read API) :
- kmjung
- vachan-shetty

reviewers (FhirIO) :
- msbukal

reviewers (DatastoreIO) :
- pcostell

reviewers (FirestoreIO) :
- pcostell

reviewers (PubsubLiteIO) :
- dpcollins-google

reviewers (all GCP connectors):
- lukecwik
- chamikaramj
- pabloem
- ihji
- johnjcasey
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,13 @@
*
* <p>Please see <a href="https://cloud.google.com/bigquery/access-control">BigQuery Access Control
* </a> for security and permission related information specific to BigQuery.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@SuppressWarnings({
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@
* <p>Permission requirements depend on the {@link PipelineRunner} that is used to execute the
* pipeline. Please refer to the documentation of corresponding {@link PipelineRunner
* PipelineRunners} for more details.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@SuppressWarnings({
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,11 @@
* above transforms. In such a case, all the Cloud Datastore API calls are directed to the Emulator.
*
* @see PipelineRunner
* <h3>Updates to the connector code</h3>
* For any updates to this connector, please consider involving corresponding code reviewers
* mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@SuppressWarnings({
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,13 @@
* listSearchResult.getKeyedResources(); // KV<"Alice-Bob-Search", JsonArray of results>
*
* </pre>
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned
* <a href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@SuppressWarnings({
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@
* <p>Permission requirements depend on the {@link PipelineRunner} that is used to execute the Beam
* pipeline. Please refer to the documentation of corresponding {@link PipelineRunner
* PipelineRunners} for more details.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@SuppressWarnings({
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@
*
* <p>For the differences between this and Google Pub/Sub, please refer to the <a
* href="https://cloud.google.com/pubsub/docs/choosing-pubsub-or-lite">product documentation</a>.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@Experimental
public final class PubsubLiteIO {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,13 @@
*
* <p>{@link Write} can be used as a streaming sink, however as with batch mode note that the write
* order of individual {@link Mutation}/{@link MutationGroup} objects is not guaranteed.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant significant updates to this I/O connector, please consider involving
* corresponding code reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@Experimental(Kind.SOURCE_SINK)
@SuppressWarnings({
Expand Down
7 changes: 7 additions & 0 deletions sdks/java/io/kafka/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs at https://s.apache.org/beam-owners

reviewers:
- aromanenko-dev
- chamikaramj
- lukecwik
- johnjcasey
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,12 @@
* ensure that the version included with the application is compatible with the version of your
* Kafka cluster. Kafka client usually fails to initialize with a clear error message in case of
* incompatibility.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant significant updates to this I/O connector, please consider involving
* corresponding code reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/kafka/OWNERS">here</a>.
*/
@Experimental(Kind.SOURCE_SINK)
@SuppressWarnings({
Expand Down
11 changes: 9 additions & 2 deletions sdks/python/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# See the OWNERS docs at https://s.apache.org/beam-owners

reviewers:
reviewers (all changes):
- aaltay
- charlesccychen
- tvalentyn

reviewers (all GCP I/O connectors):
- lukecwik
- chamikaramj
- pabloem
- ihji
- johnjcasey
6 changes: 6 additions & 0 deletions sdks/python/apache_beam/io/gcp/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,12 @@ def compute_table_name(row):
to BigQuery.
BigQuery IO requires values of BYTES datatype to be encoded using base64
encoding when writing to BigQuery.

**Updates to the I/O connector code**

For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

# pytype: skip-file
Expand Down
6 changes: 6 additions & 0 deletions sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@

This module uses the newer google-cloud-datastore client package. Its API was
different enough to require extensive changes to this and associated modules.

**Updates to the I/O connector code**

For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""
# pytype: skip-file

Expand Down
9 changes: 8 additions & 1 deletion sdks/python/apache_beam/io/gcp/gcsfilesystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@
# limitations under the License.
#

"""GCS file system implementation for accessing files on GCS."""
"""GCS file system implementation for accessing files on GCS.

**Updates to the I/O connector code**

For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

# pytype: skip-file

Expand Down
6 changes: 6 additions & 0 deletions sdks/python/apache_beam/io/gcp/gcsio.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@

This library evolved from the Google App Engine GCS client available at
https://github.com/GoogleCloudPlatform/appengine-gcs-client.

**Updates to the I/O connector code**

For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

# pytype: skip-file
Expand Down
6 changes: 6 additions & 0 deletions sdks/python/apache_beam/io/gcp/pubsub.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
pipelines, during remote execution.

This API is currently under development and is subject to change.

**Updates to the I/O connector code**

For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

# pytype: skip-file
Expand Down