Rename bookkeeper metrics to specify OpenMetrics #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
reviewed
Jul 15, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcherImpl.java
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java
Show resolved
Hide resolved
|
@hangc0276 I don't think it's necessary to modify these variable names. Let's keep the |
hangc0276
approved these changes
Jul 16, 2022
11 tasks
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md A COUNTER needs `metrics_name_total` or `metrics_name_created` This PR contains metric name broken changes. ### Modifications Rename counter's `_count` to `_total` ### metrics name broken changes - rename `FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER` to `FAILED_TO_RESOLVE_NETWORK_LOCATION_TOTAL` - rename `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNT` to `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_TOTAL` - rename `ACTIVE_ENTRY_LOG_COUNT` to `ACTIVE_ENTRY_LOG_TOTAL` - rename `MAJOR_COMPACTION_COUNT` to `MAJOR_COMPACTION_TOTAL` - rename `MINOR_COMPACTION_COUNT` to `MINOR_COMPACTION_TOTAL` - rename `ACTIVE_LEDGER_COUNT` to `ACTIVE_LEDGER_TOTAL` - rename `DELETED_LEDGER_COUNT` to `DELETED_LEDGER_TOTAL` - rename `JOURNAL_FORCE_WRITE_GROUPING_COUNT` to `JOURNAL_FORCE_WRITE_GROUPING_TOTAL` ### Also see - apache/pulsar#13785 - apache/pulsar#16591 - apache/pulsar#16610 - apache/pulsar#16611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md
A COUNTER needs
metrics_name_totalormetrics_name_createdThis PR contains metric name broken changes.
Modifications
Rename counter's
_countto_totalmetrics name broken changes
FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTERtoFAILED_TO_RESOLVE_NETWORK_LOCATION_TOTALENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNTtoENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_TOTALACTIVE_ENTRY_LOG_COUNTtoACTIVE_ENTRY_LOG_TOTALMAJOR_COMPACTION_COUNTtoMAJOR_COMPACTION_TOTALMINOR_COMPACTION_COUNTtoMINOR_COMPACTION_TOTALACTIVE_LEDGER_COUNTtoACTIVE_LEDGER_TOTALDELETED_LEDGER_COUNTtoDELETED_LEDGER_TOTALJOURNAL_FORCE_WRITE_GROUPING_COUNTtoJOURNAL_FORCE_WRITE_GROUPING_TOTALAlso see