Bump prometheus client version from 0.5.0 to 0.15.0 #13785

hezhangjian · 2022-01-17T09:20:49Z

Motivation

prometheus simpleclient has broken api, it makes pulsar-client-origin can not well used with other libraries
specify OpenMetrics

This PR contains metric name broken changes.

Modifications

Bump prometheus client version from 0.5.0 to 0.15.0

changes

bump the client version
rename the field prometheus client UNTYPED to UNKNOWN
OpenMetrics's counter name needs a _total suffix

metrics name broken changes

rename pulsar_expired_token_count to pulsar_expired_token_total
rename pulsar_authentication_success_count to pulsar_authentication_success_total
rename pulsar_authentication_failures_count to pulsar_authentication_failures_total
rename pulsar_sink_sink_exceptions_total_1min to pulsar_sink_sink_exceptions_1min_total
rename pulsar_source_received_total_1min to pulsar_source_received_1min_total
rename pulsar_source_written_total_1min to pulsar_source_written_1min_total
rename pulsar_source_source_total_1min to pulsar_source_source_exceptions_1min_total
rename pulsar_source_system_exceptions_total_1min to pulsar_source_system_exceptions_1min_total
rename pulsar_function_received_total_1min to pulsar_function_received_1min_total
rename pulsar_function_user_exceptions_total_1min to pulsar_function_user_exceptions_1min_total
rename pulsar_function_system_exceptions_total_1min to pulsar_function_system_exceptions_1min_total
rename pulsar_function_processed_successfully_total_1min to pulsar_function_processed_successfully_1min_total
rename pulsar_function_received_total_1min to pulsar_function_received_1min_total
rename pulsar_function_user_exceptions_total_1min to pulsar_function_user_exceptions_1min_total
rename pulsar_function_system_exceptions_total_1min to pulsar_function_system_exceptions_1min_total
rename pulsar_function_processed_successfully_total_1min to pulsar_function_processed_successfully_1min_total
rename pulsar_sink_received_total_1min to pulsar_sink_received_1min_total
rename pulsar_sink_written_total_1min to pulsar_sink_written_1min_total
rename pulsar_sink_sink_exceptions_total_1min to pulsar_sink_sink_exceptions_1min_total
rename pulsar_sink_system_exceptions_total_1min to pulsar_sink_system_exceptions_1min_total
rename pulsar_sink_received_total_1min to pulsar_sink_received_1min_total
rename pulsar_sink_written_total_1min to pulsar_sink_written_1min_total
rename pulsar_sink_sink_exceptions_total_1min to pulsar_sink_sink_exceptions_1min_total
rename pulsar_sink_system_exceptions_total_1min to pulsar_sink_system_exceptions_1min_total

Documentation

Check the box below or label this PR directly.

Need to update docs?

doc
As mentioned above, the metrics name has changed

mattisonchao

LGTM +1

hezhangjian · 2022-01-20T13:10:52Z

prometheus/client_java#615
introduced a breaking change, need discuss

…ats/prometheus/PrometheusMetricsGeneratorUtils.java Co-authored-by: Michael Marshall <[email protected]>

hezhangjian · 2022-07-13T13:50:06Z

/pulsarbot run-failure-checks

dave2wave · 2022-07-13T16:34:36Z

Version 0.16.0 is now available: https://github.com/prometheus/client_java/releases

### Motivation - prometheus `simpleclient` has broken api, it makes `pulsar-client-origin` can not well used with other libraries - specify `OpenMetrics` This PR contains metric name broken changes. ### Modifications Bump prometheus client version from 0.5.0 to 0.15.0 ### changes - bump the client version - rename the field prometheus client `UNTYPED` to `UNKNOWN` - `OpenMetrics`'s counter name needs a `_total` suffix ### metrics name broken changes - rename `pulsar_expired_token_count` to `pulsar_expired_token_total` - rename `pulsar_authentication_success_count` to `pulsar_authentication_success_total` - rename `pulsar_authentication_failures_count` to `pulsar_authentication_failures_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_source_received_total_1min` to `pulsar_source_received_1min_total` - rename `pulsar_source_written_total_1min` to `pulsar_source_written_1min_total` - rename `pulsar_source_source_total_1min` to `pulsar_source_source_exceptions_1min_total ` - rename `pulsar_source_system_exceptions_total_1min` to `pulsar_source_system_exceptions_1min_total ` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total ` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-required` As mentioned above, the metrics name has changed

michaeljmarshall · 2022-07-14T02:53:11Z

@dave2wave - thanks for sharing. Based on two of the enhancements, we should probably upgrade before cutting the 2.11 branch. Here are the two that we should specifically benefit from:

[ENHANCEMENT] Reduce the number of core threads in HTTPServer from 5 to 1. The HTTPServer will still start up to 5 threads on demand if there are parallel requests, but it will use only 1 thread as long as requests are sequential (prometheus/client_java#786).
[ENHANCEMENT] Optimize metric name sanitization: Replace the regular expression with a hard-coded optimized algorithm to improve performance (prometheus/client_java#777). Thanks @fwbrasil

hezhangjian · 2022-07-14T02:54:22Z

@dave2wave @michaeljmarshall Thanks, I will follow up on this

### Motivation - prometheus `simpleclient` has broken api, it makes `pulsar-client-origin` can not well used with other libraries - specify `OpenMetrics` This PR contains metric name broken changes. ### Modifications Bump prometheus client version from 0.5.0 to 0.15.0 ### changes - bump the client version - rename the field prometheus client `UNTYPED` to `UNKNOWN` - `OpenMetrics`'s counter name needs a `_total` suffix ### metrics name broken changes - rename `pulsar_expired_token_count` to `pulsar_expired_token_total` - rename `pulsar_authentication_success_count` to `pulsar_authentication_success_total` - rename `pulsar_authentication_failures_count` to `pulsar_authentication_failures_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_source_received_total_1min` to `pulsar_source_received_1min_total` - rename `pulsar_source_written_total_1min` to `pulsar_source_written_1min_total` - rename `pulsar_source_source_total_1min` to `pulsar_source_source_exceptions_1min_total ` - rename `pulsar_source_system_exceptions_total_1min` to `pulsar_source_system_exceptions_1min_total ` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total ` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-required` As mentioned above, the metrics name has changed

### Motivation See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md A COUNTER needs `metrics_name_total` or `metrics_name_created` This PR contains metric name broken changes. ### Modifications Rename counter's `_count` to `_total` ### metrics name broken changes - rename `FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER` to `FAILED_TO_RESOLVE_NETWORK_LOCATION_TOTAL` - rename `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNT` to `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_TOTAL` - rename `ACTIVE_ENTRY_LOG_COUNT` to `ACTIVE_ENTRY_LOG_TOTAL` - rename `MAJOR_COMPACTION_COUNT` to `MAJOR_COMPACTION_TOTAL` - rename `MINOR_COMPACTION_COUNT` to `MINOR_COMPACTION_TOTAL` - rename `ACTIVE_LEDGER_COUNT` to `ACTIVE_LEDGER_TOTAL` - rename `DELETED_LEDGER_COUNT` to `DELETED_LEDGER_TOTAL` - rename `JOURNAL_FORCE_WRITE_GROUPING_COUNT` to `JOURNAL_FORCE_WRITE_GROUPING_TOTAL` ### Also see - apache/pulsar#13785 - apache/pulsar#16591 - apache/pulsar#16610 - apache/pulsar#16611

momo-jun · 2022-07-21T03:15:27Z

The doc update has been included in the PR. The doc-required label needs a refresh.
//cc @Anonymitaet

### Motivation - prometheus `simpleclient` has broken api, it makes `pulsar-client-origin` can not well used with other libraries - specify `OpenMetrics` This PR contains metric name broken changes. ### Modifications Bump prometheus client version from 0.5.0 to 0.15.0 ### changes - bump the client version - rename the field prometheus client `UNTYPED` to `UNKNOWN` - `OpenMetrics`'s counter name needs a `_total` suffix ### metrics name broken changes - rename `pulsar_expired_token_count` to `pulsar_expired_token_total` - rename `pulsar_authentication_success_count` to `pulsar_authentication_success_total` - rename `pulsar_authentication_failures_count` to `pulsar_authentication_failures_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_source_received_total_1min` to `pulsar_source_received_1min_total` - rename `pulsar_source_written_total_1min` to `pulsar_source_written_1min_total` - rename `pulsar_source_source_total_1min` to `pulsar_source_source_exceptions_1min_total ` - rename `pulsar_source_system_exceptions_total_1min` to `pulsar_source_system_exceptions_1min_total ` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total ` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-required` As mentioned above, the metrics name has changed (cherry picked from commit c0b4d57)

eolivelli · 2022-09-02T07:57:32Z

This change cannot go to branch-2.10
it is a important behaviour change

@Jason918 please revert

This reverts commit 329db09.

Jason918 · 2022-09-02T08:25:19Z

This change cannot go to branch-2.10
it is a important behaviour change

@eolivelli
Sure, thanks for the reminding. Sorry I didn't notice the release/important-notice.
I add this because #16591 depends on this.
I have reverted both.

### Motivation See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md A COUNTER needs `metrics_name_total` or `metrics_name_created` This PR contains metric name broken changes. ### Modifications Rename counter's `_count` to `_total` ### metrics name broken changes - rename `FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER` to `FAILED_TO_RESOLVE_NETWORK_LOCATION_TOTAL` - rename `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNT` to `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_TOTAL` - rename `ACTIVE_ENTRY_LOG_COUNT` to `ACTIVE_ENTRY_LOG_TOTAL` - rename `MAJOR_COMPACTION_COUNT` to `MAJOR_COMPACTION_TOTAL` - rename `MINOR_COMPACTION_COUNT` to `MINOR_COMPACTION_TOTAL` - rename `ACTIVE_LEDGER_COUNT` to `ACTIVE_LEDGER_TOTAL` - rename `DELETED_LEDGER_COUNT` to `DELETED_LEDGER_TOTAL` - rename `JOURNAL_FORCE_WRITE_GROUPING_COUNT` to `JOURNAL_FORCE_WRITE_GROUPING_TOTAL` ### Also see - apache/pulsar#13785 - apache/pulsar#16591 - apache/pulsar#16610 - apache/pulsar#16611

nicoloboschi previously approved these changes Jan 17, 2022

View reviewed changes

github-actions bot assigned hezhangjian Jan 17, 2022

github-actions bot added the doc-label-missing label Jan 17, 2022

hezhangjian added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jan 17, 2022

apache deleted a comment from github-actions bot Jan 17, 2022

mattisonchao previously approved these changes Jan 17, 2022

View reviewed changes

hezhangjian force-pushed the bump-prometheus-cli-version branch from b190f84 to f2d9af8 Compare January 18, 2022 00:57

Jason918 previously approved these changes Jan 18, 2022

View reviewed changes

codelipenghui added this to the 2.10.0 milestone Jan 18, 2022

codelipenghui previously approved these changes Jan 18, 2022

View reviewed changes

hezhangjian force-pushed the bump-prometheus-cli-version branch from 4bea6a1 to 84181c9 Compare January 20, 2022 08:41

hezhangjian changed the title ~~Bump prometheus client version from 0.5.0 to 0.14.1~~ [WIP] Bump prometheus client version from 0.5.0 to 0.14.1 Jan 20, 2022

codelipenghui modified the milestones: 2.10.0, 2.11.0 Jan 21, 2022

hezhangjian mentioned this pull request Feb 11, 2022

[Security] Should Upgrade Log4j to 2.17.1 in Prometheus Client dependency #14237

Closed

congbobo184 dismissed stale reviews from codelipenghui, Jason918, mattisonchao, and nicoloboschi via 84181c9 February 16, 2022 02:58

github-actions bot added the lifecycle/stale label Mar 19, 2022

hezhangjian force-pushed the bump-prometheus-cli-version branch 2 times, most recently from a2a6238 to 7e5b04f Compare May 13, 2022 12:31

hezhangjian force-pushed the bump-prometheus-cli-version branch 3 times, most recently from 9b5ff9b to 2b50604 Compare May 22, 2022 04:41

github-actions bot removed the lifecycle/stale label May 23, 2022

hezhangjian force-pushed the bump-prometheus-cli-version branch 2 times, most recently from 460171e to 466a663 Compare May 25, 2022 12:05

fix some total

8e9d266

hezhangjian force-pushed the bump-prometheus-cli-version branch from 3d62ce9 to 8e9d266 Compare July 13, 2022 02:58

Update pulsar-broker-common/src/main/java/org/apache/pulsar/broker/st…

2efe4ad

…ats/prometheus/PrometheusMetricsGeneratorUtils.java Co-authored-by: Michael Marshall <[email protected]>

hezhangjian merged commit c0b4d57 into apache:master Jul 13, 2022

hezhangjian deleted the bump-prometheus-cli-version branch July 13, 2022 15:45

michaeljmarshall approved these changes Jul 14, 2022

View reviewed changes

hezhangjian mentioned this pull request Jul 15, 2022

Rename bookkeeper metrics to specify OpenMetrics apache/bookkeeper#3406

Merged

tjiuming mentioned this pull request Jul 20, 2022

[monitor][txn] Add metrics for transaction #15140

Merged

4 tasks

github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-required Your PR changes impact docs and you will update later. labels Jul 21, 2022

Jason918 added the release/2.10.2 label Sep 1, 2022

Jason918 added the cherry-picked/branch-2.10 label Sep 2, 2022

Jason918 added a commit that referenced this pull request Sep 2, 2022

Revert "Bump prometheus client version from 0.5.0 to 0.15.0 (#13785)"

ebf732b

This reverts commit 329db09.

Jason918 removed cherry-picked/branch-2.10 release/2.10.2 labels Sep 2, 2022

Jason918 mentioned this pull request Sep 2, 2022

Bump prometheus client version from 0.15.0 to 0.16.0 #16591

Merged

1 task

This was referenced Dec 29, 2022

[BUG] - KoP CPU usage is 10 times higher than Pulsar on the broker side streamnative/kop#1652

Open

[branch-2.10] Use a more efficient implementation of sanitizeMetricName streamnative/kop#1654

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump prometheus client version from 0.5.0 to 0.15.0 #13785

Bump prometheus client version from 0.5.0 to 0.15.0 #13785

hezhangjian commented Jan 17, 2022 •

edited

Loading

mattisonchao left a comment

hezhangjian commented Jan 20, 2022 •

edited

Loading

hezhangjian commented Jul 13, 2022

dave2wave commented Jul 13, 2022

michaeljmarshall commented Jul 14, 2022 •

edited

Loading

hezhangjian commented Jul 14, 2022

momo-jun commented Jul 21, 2022

eolivelli commented Sep 2, 2022

Jason918 commented Sep 2, 2022

Bump prometheus client version from 0.5.0 to 0.15.0 #13785

Bump prometheus client version from 0.5.0 to 0.15.0 #13785

Conversation

hezhangjian commented Jan 17, 2022 • edited Loading

Motivation

Modifications

changes

metrics name broken changes

Documentation

mattisonchao left a comment

Choose a reason for hiding this comment

hezhangjian commented Jan 20, 2022 • edited Loading

hezhangjian commented Jul 13, 2022

dave2wave commented Jul 13, 2022

michaeljmarshall commented Jul 14, 2022 • edited Loading

hezhangjian commented Jul 14, 2022

momo-jun commented Jul 21, 2022

eolivelli commented Sep 2, 2022

Jason918 commented Sep 2, 2022

hezhangjian commented Jan 17, 2022 •

edited

Loading

hezhangjian commented Jan 20, 2022 •

edited

Loading

michaeljmarshall commented Jul 14, 2022 •

edited

Loading