Compilation fails for gRPC applications in dev mode

[jamesnetherton]

Bug description

I finally realize why Quarkus does not exclude Findbugs in grpc-common. Seems gRPC has a number of occurrences of javax.annotation.CheckReturnValue:

https://github.com/search?q=repo%3Agrpc%2Fgrpc-java+CheckReturnValue&type=code&p=1

Which results in the following compilation error because we are excluding findbugs here:

https://github.com/apache/camel-quarkus/blob/main/extensions/grpc/runtime/pom.xml#L41-L45

Seems to not occur outside of dev mode though.

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] cannot access javax.annotation.CheckReturnValue
  class file for javax.annotation.CheckReturnValue not found
[INFO] 1 error
[INFO] -------------------------------------------------------------

The simplest fix would be to remove the Findbugs exclusion.

[jamesnetherton]

@ppalaga Is there any way of ignoring the dependency ban for Findbugs exclusively in the grpc/runtime module? Or would the ban have to be removed globally (maybe undesirable)?

[ppalaga]

Yeah, I also recollect gRPC was a special about findbugs.

We could try to redefine the rules in this module, something like

                    <plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-enforcer-plugin</artifactId>
                        <dependencies>
                            <dependency>
                                <groupId>io.quarkus</groupId>
                                <artifactId>quarkus-enforcer-rules</artifactId>
                                <version>${quarkus.version}</version>
                            </dependency>
                            <dependency>
                                <groupId>org.l2x6.cq</groupId>
                                <artifactId>cq-filtered-external-enforcer-rules</artifactId>
                                <version>${cq-plugin.version}</version>
                            </dependency>
                        </dependencies>
                        <executions>
                            <execution>
                                <id>camel-quarkus-enforcer-rules</id>
                                <goals>
                                    <goal>enforce</goal>
                                </goals>
                                <configuration>
                                    <rules>
                                        <requireJavaVersion>
                                            <version>11</version>
                                        </requireJavaVersion>
                                        <dependencyConvergence />
                                        <filteredExternalRules>
                                            <location>classpath:enforcer-rules/quarkus-require-maven-version.xml</location>
                                        </filteredExternalRules>
                                        <filteredExternalRules>
                                            <location>classpath:enforcer-rules/quarkus-banned-dependencies.xml</location>
                                            <xsltLocation>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/quarkus-banned-dependencies.xsl</xsltLocation>
                                        </filteredExternalRules>
                                        <filteredExternalRules>
                                            <location>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/camel-quarkus-banned-dependencies.xml</location>
<!-- Exclude findbugs in this module -->
                                            <xsltLocation>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/exclude-findbugs.xsl</xsltLocation>
                                        </filteredExternalRules>
                                        <filteredExternalRules>
                                            <location>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/camel-quarkus-banned-dependencies-spring.xml</location>
                                        </filteredExternalRules>
                                    </rules>
                                </configuration>
                            </execution>
                        </executions>
                    </plugin>

where tooling/enforcer-rules/exclude-findbugs.xsl could be adapted from the existing tooling/enforcer-rules/quarkus-banned-dependencies.xsl

[ppalaga]

It's actually "allow findbugs" rather than "exclude findbugs"