Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove findbugs exclusion since it is needed by quarkus-grpc-common #1587

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Nov 8, 2024

No description provided.

@zhfeng zhfeng requested a review from a team as a code owner November 8, 2024 13:19
@ppalaga
Copy link
Contributor

ppalaga commented Nov 10, 2024

@zhfeng could you please explain, what problem would this change solve? There is no dependency on GRPC in Quarkus CXF.

@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 10, 2024

Well, it is a transitive dep via io.quarkus:quarkus-opentelemetry. I suppose there might be a potential issue like

@ppalaga
Copy link
Contributor

ppalaga commented Nov 12, 2024

OK, thanks, I see that io.quarkus:quarkus-opentelemetry actually depends on quarkus-grpc-common

@ppalaga ppalaga merged commit 05bea0d into quarkiverse:main Nov 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants