CB-11412 improve template implementation #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carynbear
force-pushed
the
CB-11412-remove-linking
branch
from
5139dee to
b0f33e1
Compare
| }; | ||
|
|
||
| var configSubDirPkgJson = { | ||
| lib: { |
There was a problem hiding this comment.
nitpick: Look like lib obj here has an extra tab
|
LGTM! |
carynbear
force-pushed
the
CB-11412-remove-linking
branch
from
b0f33e1 to
d46658b
Compare
|
@stevengill fixed up the little details |
| pkgjson.name = cfg.name.toLowerCase(); | ||
| } | ||
| pkgjson.version = '1.0.0'; | ||
| fs.writeFile(path.join(dir, 'package.json'), JSON.stringify(pkgjson), function (err) { |
There was a problem hiding this comment.
Lets maybe do the write operation as Sync and lets add spaces to the new package.json file. See
carynbear
force-pushed
the
CB-11412-remove-linking
branch
2 times, most recently
from
39f58de to
3b9fedd
Compare
carynbear
force-pushed
the
CB-11412-remove-linking
branch
from
3b9fedd to
7417db0
Compare
devgeeks
added a commit
to phonegap/phonegap-template-react-hot-loader
that referenced
this pull request
Jun 16, 2016
In preparation for apache/cordova-lib#456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed symlinking.