Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

CB-11412 Update templates to designate template source dir #5

Merged
merged 1 commit into from
Jun 15, 2016

Conversation

carynbear
Copy link
Contributor

No description provided.

@devgeeks
Copy link
Contributor

I assume these are in prep for the changes to templates and should not be pulled in yet?

@stevengill
Copy link

Probably needs a quick review but it should work with existing cordova as well next one with the changes

@devgeeks
Copy link
Contributor

OK. I'll review it today then!

@devgeeks devgeeks merged commit fa2b565 into phonegap:master Jun 15, 2016
@mwbrooks
Copy link
Collaborator

I left a few comments on phonegap/phonegap-template-framework7#6 that are related to this one.

@mwbrooks
Copy link
Collaborator

Heads up, I noticed that this was merged. Will it not break the current releases of the PhoneGap / Cordova CLIs? Merging it prevents us from doing any patches until the next Cordova update.

@stevengill
Copy link

existing cordova-cli template work should work with this updated template.

@devgeeks
Copy link
Contributor

I tested it with:

~ Brodie 💀  cordova --version
6.2.0
~ Brodie 💀  phonegap --version
6.2.6

And it worked fine. It's not published to npm quite yet though just in case something comes up with the Desktop app review of hello-world

@stevengill
Copy link

Yeah, i tested it with cordova 6.2.0 and with the new PR [1] by @carynbear enhancing template support. Works with both.

With the new PR [1], package.json name and version field will also be updated.

@devgeeks if you want, you can modify the default values in the package.json inside template_src. So the name, version, author, etc can all be dumb default values. Something similar to [2]. Of course, you will probably want to leave in the scripts object and dependencies.

[1] apache/cordova-lib#456
[2] https://github.com/phonegap/phonegap-template-blank/blob/master/template_src/package.json

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

4 participants