Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src and binaries include needs correct LICENSE/NOTICE #839

Closed
hdalsania opened this issue Sep 8, 2023 · 0 comments · Fixed by #896
Closed

src and binaries include needs correct LICENSE/NOTICE #839

hdalsania opened this issue Sep 8, 2023 · 0 comments · Fixed by #896
Assignees
@shanedell
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation legal
Milestone
1.4.0

Comments

@hdalsania
Copy link
Collaborator

hdalsania commented Sep 8, 2023 •
edited
Loading

  • typescript is listed in the NONOTICE file but is a dev Dependency and isn't bundled in the vsix file and so does not need to be mentioned
  • org.apache.tika.tika-core-2.7.0.jar is bundled as part of omega-edit. It is licensed under ALv2 so is compatible, but its NOTICE content is
    is missing from build/package/NOTICE

Source of this ticket is approval VOTE email from @stevedlawrence for v1.3.1-rc2.
@hdalsania hdalsania added the dependencies Pull requests that update a dependency file label Sep 8, 2023
@hdalsania hdalsania added this to the 1.4.0 milestone Sep 8, 2023
@hdalsania hdalsania added legal documentation Improvements or additions to documentation labels Sep 12, 2023
shanedell added a commit to shanedell/daffodil-vscode that referenced this issue Nov 9, 2023
@shanedell
Update NONOTICE and NOTICE
2f505cd 
- Add missing dependcies to NOTICE and NOTICE files.
- Clean up the NOTICE information for Apache Pekko:
  - Everything used to be a single repo but seems they split into multiple now.
- Fix version in package.json to go back to a SNAPSHOT version.

Closes apache#839
@shanedell shanedell mentioned this issue Nov 9, 2023
Merged
shanedell added a commit to shanedell/daffodil-vscode that referenced this issue Nov 29, 2023
@shanedell
Update NONOTICE and NOTICE
2e0b170 
- Add missing dependcies to NOTICE and NOTICE files.
- Clean up the NOTICE information for Apache Pekko:
  - Everything used to be a single repo but seems they split into multiple now.
- Fix version in package.json to go back to a SNAPSHOT version.

Closes apache#839
shanedell added a commit that referenced this issue Nov 29, 2023
@shanedell
Update NONOTICE and NOTICE
f2d880a 
- Add missing dependcies to NOTICE and NOTICE files.
- Clean up the NOTICE information for Apache Pekko:
  - Everything used to be a single repo but seems they split into multiple now.
- Fix version in package.json to go back to a SNAPSHOT version.

Closes #839
@github-project-automation github-project-automation bot moved this from Todo to Done in daffodil-vscode v1.4.0 Nov 29, 2023
scholarsmate pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Dec 6, 2023
@shanedell @scholarsmate
Update NONOTICE and NOTICE
024db97 
- Add missing dependcies to NOTICE and NOTICE files.
- Clean up the NOTICE information for Apache Pekko:
  - Everything used to be a single repo but seems they split into multiple now.
- Fix version in package.json to go back to a SNAPSHOT version.

Closes apache#839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanedell shanedell

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation legal
Projects
No open projects
daffodil-vscode v1.4.0
Status: Done
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Update NONOTICE and NOTICE shanedell/daffodil-vscode
2 participants
@shanedell @hdalsania