Update NONOTICE and NOTICE #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanedell
requested review from
arosien,
mbeckerle,
scholarsmate,
stevedlawrence,
stricklandrbls,
rthomas320,
michael-hoke,
NolanMatt and
nlewis05
scholarsmate
reviewed
Nov 9, 2023
| @@ -2,7 +2,7 @@ | |||
| "name": "apache-daffodil-vscode", | |||
| "displayName": "Apache Daffodil™ Extension for Visual Studio Code", | |||
| "description": "Apache Daffodil™ Extension for Visual Studio Code providing DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data editor", | |||
| "version": "1.3.1", | |||
| "version": "1.4.0-SNAPSHOT", | |||
There was a problem hiding this comment.
This is interesting, and I agree with this change. After we do a release, we should probably do this as the next merged commit, until the next release and so on.
NolanMatt
approved these changes
Nov 13, 2023
- Add missing dependcies to NOTICE and NOTICE files. - Clean up the NOTICE information for Apache Pekko: - Everything used to be a single repo but seems they split into multiple now. - Fix version in package.json to go back to a SNAPSHOT version. Closes apache#839
shanedell
force-pushed
the
update-notice-files
branch
from
2f505cd to
2e0b170
Compare
|
@mbeckerle @stevedlawrence @arosien @stricklandrbls @rthomas320 Would one of you mind giving this a review/approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update NONOTICE and NOTICE
Closes #839