Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests in joins.rs to sqllogictest #6302

Closed
Tracked by #6195
alamb opened this issue May 9, 2023 · 2 comments · Fixed by #6642
Closed
Tracked by #6195

Port tests in joins.rs to sqllogictest #6302

alamb opened this issue May 9, 2023 · 2 comments · Fixed by #6642

Comments

@alamb
Copy link
Contributor

alamb commented May 9, 2023

Is your feature request related to a problem or challenge?

Part of #6195. We are trying to keep the DataFusion code base clean and easy to contribute to and modify. Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily

Describe the solution you'd like

Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/joins.rs to joins.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests/test_files

This is a subtantial task -- and perhaps is done best in several smaller PRs

Notes:

  1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests
  2. If you have questions or hit issues, please let me know

Describe alternatives you've considered

No response

Additional context

No response

@parkma99
Copy link
Contributor

parkma99 commented May 9, 2023

I'm going to work it

@alamb
Copy link
Contributor Author

alamb commented May 9, 2023

Thank you @parkma99 -- really apprecaited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants