Port tests in joins.rs to sqllogictes #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
40 tasks
alamb
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Thank you @jiangzhx -- this look great to me.
cc @aprimadi and @mingmwang
| .unwrap(); | ||
| } | ||
|
|
||
| pub async fn register_hashjoin_datatype_table(ctx: &SessionContext) { |
There was a problem hiding this comment.
likewise we could port this to .sql as well
There was a problem hiding this comment.
I had some time so I made a PR to do this in #6656
| @@ -212,3 +220,311 @@ fn register_nan_table(ctx: &SessionContext) { | |||
| .unwrap(); | |||
| ctx.register_batch("test_float", data).unwrap(); | |||
| } | |||
|
|
|||
| pub async fn register_timestamps_table(ctx: &SessionContext) { | |||
There was a problem hiding this comment.
I think this is code we can potentially port to sql (using arrow-typeof), but we can also handle that as a follow on PR too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6302.
Subtask of #6195
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?