Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port remaining sql integration tests from rust to sqllogictest #6195

Closed
40 tasks done
Tracked by #4460
alamb opened this issue May 2, 2023 · 2 comments · Fixed by #9014
Closed
40 tasks done
Tracked by #4460

Port remaining sql integration tests from rust to sqllogictest #6195

alamb opened this issue May 2, 2023 · 2 comments · Fixed by #9014
Labels
enhancement New feature or request good first issue Good for newcomers sqllogictest SQL Logic Tests (.slt)

Comments

@alamb
Copy link
Contributor

alamb commented May 2, 2023

Is your feature request related to a problem or challenge?

As described in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests DataFusion has many tests that use the sqllogictest framework which is easy to write and update compared to rust tests

We still have a non trivial number of old tests that are written in Rust and run in the sql integration test:
https://arrow.apache.org/datafusion/contributor-guide/index.html#rust-integration-tests

cargo test -p datafusion --test sql_integration

This ticket tracks the work to port the tests from rust to sqllogictests

Describe the solution you'd like

Port tests from datafusion/core/tests/sql to sqllogictests in datafusion/core/tests/sqllogictests/test_files

For each test, the goal is to:

  1. Port as many tests as possiible (follow the example of Port test in select.rs to sqllogic #6158 or one of the other tests linked to Port sql tests written in Rust to sqllogictests #4495)

Then we can figure out what to do with the tests that can not be ported easily

Remaining items:

Describe alternatives you've considered

No response

Additional context

Follow on to #4495

Marking this as a good first issue as there are many examples and it will get people familiar with how to run tests and how to use datafusion as a library, while also helping the community

@alamb alamb added enhancement New feature or request good first issue Good for newcomers labels May 2, 2023
@alamb alamb added the sqllogictest SQL Logic Tests (.slt) label May 2, 2023
@jiangzhx
Copy link
Contributor

jiangzhx commented Jun 12, 2023

i have started working on #6642

@alamb
Copy link
Contributor Author

alamb commented Jan 28, 2024

Thank you to everyone who helped get this done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants