-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port remaining sql integration tests from rust
to sqllogictest
#6195
Closed
40 tasks done
Tracked by
#4460
Labels
enhancement
New feature or request
good first issue
Good for newcomers
sqllogictest
SQL Logic Tests (.slt)
Comments
alamb
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
May 2, 2023
This was referenced May 2, 2023
This was referenced May 3, 2023
i have started working on #6642 |
This was referenced Nov 15, 2023
This was referenced Nov 15, 2023
This was referenced Nov 16, 2023
13 tasks
7 tasks
3 tasks
This was referenced Jan 27, 2024
Thank you to everyone who helped get this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
sqllogictest
SQL Logic Tests (.slt)
Is your feature request related to a problem or challenge?
As described in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests DataFusion has many tests that use the sqllogictest framework which is easy to write and update compared to rust tests
We still have a non trivial number of old tests that are written in Rust and run in the sql integration test:
https://arrow.apache.org/datafusion/contributor-guide/index.html#rust-integration-tests
This ticket tracks the work to port the tests from rust to sqllogictests
Describe the solution you'd like
Port tests from datafusion/core/tests/sql to sqllogictests in datafusion/core/tests/sqllogictests/test_files
For each test, the goal is to:
Then we can figure out what to do with the tests that can not be ported easily
Remaining items:
wildcard.rs
to sqllogictest #6216expr.rs
to sqllogictest #6210functions.rs
to sqllogictest #6211identifiers.rs
to sqllogictest #6212set_variable.rs
to sqllogictest #6213unicode.rs
to sqllogictest #6214union.rs
to sqllogictest #6215avro.rs
to sqllogictest #6299errors.rs
to context.rs #6298explain.rs
to sqllogictests #6297functions.rs
to sqllogictest #6300information_schema.rs
to sqllogictest #6301joins.rs
to sqllogictest #6302json.rs
to sqllogictest #6303subqueries.rs
from rust to sqllogictest #6668aggregates.rs
to sqllogictest #8194arrow_files.rs
to sqllogictest #8195create_drop.rs
to sqllogictest #8196csv_files.rs
to sqllogictest #8197describe.rs
to sqllogictest #8198displayable.rs
to sqllogictest #8199explain_analyze.rs
to sqllogictest #8200expr.rs
to sqllogictest #8201group_by.rs
to sqllogictest #8202joins.rs
to sqllogictest #8203limit.rs
to sqllogictest #8204order.rs
to sqllogictest #8205parquet.rs
to sqllogictest #8206parquet_schema.rs
to sqllogictest #8207partitioned_csv.rs
to sqllogictest #8208predicates.rs
to sqllogictest #8209projection.rs
to sqllogictest #8210references.rs
to sqllogictest #8211repartition.rs
to sqllogictest #8212select.rs
to sqllogictest #8213sql_api.rs
to sqllogictest #8214subqueries.rs
to sqllogictest #8215timestamp.rs
to sqllogictest #8216Describe alternatives you've considered
No response
Additional context
Follow on to #4495
Marking this as a good first issue as there are many examples and it will get people familiar with how to run tests and how to use datafusion as a library, while also helping the community
The text was updated successfully, but these errors were encountered: