-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ballista-cli
crate
#2495
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e3ad9f2
Add new ballista-cli crate
andygrove a583903
update dependency diagram
andygrove c560fb6
re-use PrintFormat from datafusion-cli
andygrove 31d88c0
re-use PrintOptions from datafusion-cli
andygrove 0b549c5
re-use Helper
andygrove 3ea9404
re-use functions
andygrove cbd9638
update dev scripts
andygrove 34d1d7b
update diagram and docs
andygrove 0c99641
stop building DataFusion CLI with ballista in CI
andygrove 50b764e
update user guide
andygrove edd2ee0
docs for building ballista-cli with docker
andygrove 7660867
make version numbers consistent with repo
andygrove cfb94fd
merge from master
andygrove e214e5c
update Cargo.lock files for CLIs and add ballista-cli to GitHub workflow
andygrove a795671
disable ballista tests
andygrove f79e6ee
fix ci
andygrove 4a4fa40
fix merge conflict
andygrove a396d47
fix
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,14 +75,6 @@ jobs: | |
env: | ||
CARGO_HOME: "/github/home/.cargo" | ||
CARGO_TARGET_DIR: "/github/home/target" | ||
- name: Check DataFusion CLI builds with ballista | ||
run: | | ||
(cd datafusion-cli && cargo check) | ||
(cd datafusion-cli && cargo check --no-default-features) | ||
(cd datafusion-cli && cargo check --features=ballista) | ||
env: | ||
CARGO_HOME: "/github/home/.cargo" | ||
CARGO_TARGET_DIR: "/github/home/target" | ||
|
||
# test the crate | ||
linux-test: | ||
|
@@ -123,9 +115,9 @@ jobs: | |
run: | | ||
export ARROW_TEST_DATA=$(pwd)/testing/data | ||
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data | ||
cargo test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We were previously only running |
||
# test datafusion examples | ||
cd datafusion-examples | ||
cargo test --no-default-features | ||
cargo run --example csv_sql | ||
cargo run --example parquet_sql | ||
cargo run --example avro_sql --features=datafusion/avro | ||
|
@@ -134,6 +126,42 @@ jobs: | |
env: | ||
CARGO_HOME: "/github/home/.cargo" | ||
CARGO_TARGET_DIR: "/github/home/target" | ||
|
||
# run ballista tests | ||
ballista-test: | ||
name: Test Ballista on AMD64 Rust ${{ matrix.rust }} | ||
needs: [linux-build-lib] | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
arch: [amd64] | ||
rust: [stable] | ||
container: | ||
image: ${{ matrix.arch }}/rust | ||
env: | ||
# Disable full debug symbol generation to speed up CI build and keep memory down | ||
# "1" means line tables only, which is useful for panic tracebacks. | ||
RUSTFLAGS: "-C debuginfo=1" | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
submodules: true | ||
- name: Cache Cargo | ||
uses: actions/cache@v2 | ||
with: | ||
path: /github/home/.cargo | ||
# this key equals the ones on `linux-build-lib` for re-use | ||
key: cargo-cache- | ||
- name: Cache Rust dependencies | ||
uses: actions/cache@v2 | ||
with: | ||
path: /github/home/target | ||
# this key equals the ones on `linux-build-lib` for re-use | ||
key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }} | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/setup-builder | ||
with: | ||
rust-version: ${{ matrix.rust }} | ||
# Ballista is currently not part of the main workspace so requires a separate test step | ||
- name: Run Ballista tests | ||
run: | | ||
|
@@ -209,6 +237,8 @@ jobs: | |
POSTGRES_PASSWORD: postgres | ||
- name: Build datafusion-cli | ||
run: (cd datafusion-cli && cargo build) | ||
- name: Build ballista-cli | ||
run: (cd ballista-cli && cargo build) | ||
- name: Test Psql Parity | ||
run: python -m pytest -v integration-tests/test_psql_parity.py | ||
env: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test
datafusion-cli
in the integration tests and we no longer support running this with ballista