-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ballista-cli
crate
#2495
Conversation
cc @liukun4515 and team |
use std::sync::Arc; | ||
|
||
/// The CLI supports using a local DataFusion context or a distributed BallistaContext | ||
pub enum Context { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can probably be simplified over time as this cli is always for ballista
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think ballista still needs a local option but it should be using a local (in-process) ballista scheduler and executor and not using datafusion directly.
Thanks @andygrove looks much better to me |
Thanks for the review @alamb. I pushed another commit to fix the |
AMD64 tests failed with |
AMD64 tests failed with |
@alamb All PR builds are failing on AMD64 with |
@alamb All PR builds are failing on AMD64 with no space left on device. Any idea what we need to do to resolve? Perhaps we can try to update the cache-key in https://github.com/apache/arrow-datafusion/blob/master/.github/workflows/rust.yml#L55 to see if something about the old caches is too large? |
Thanks. I suppose this cache just continues to grow forever and doesn't clear out old versions of deps that we no longer use? Perhaps we should include the month name in the cache so it resets periodically? |
@alamb Moving the ballista tests to a separate job fixes this. Ok to merge? |
@@ -123,9 +115,9 @@ jobs: | |||
run: | | |||
export ARROW_TEST_DATA=$(pwd)/testing/data | |||
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data | |||
cargo test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were previously only running cargo test
in the datafusion-examples
crate in this step
(cd datafusion-cli && cargo check) | ||
(cd datafusion-cli && cargo check --no-default-features) | ||
(cd datafusion-cli && cargo check --features=ballista) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test datafusion-cli
in the integration tests and we no longer support running this with ballista
I'm going to go ahead and merge to unblock other PRs and so that I can create the release candidate PR. |
Which issue does this PR close?
Closes #2493 and #2433 and #2517
Rationale for this change
Here is the new crate dependency diagram:
What changes are included in this PR?
Are there any user-facing changes?
Yes