Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](sql) Wrong result of tosql for drop column with rollup #47153

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

wyxxxcat
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32512 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 071838c545ccfee59bd44a49740b9294d88fe120, data reload: false

------ Round 1 ----------------------------------
q1	17581	5493	5354	5354
q2	2042	307	183	183
q3	10546	1226	751	751
q4	10277	950	518	518
q5	8459	2390	2091	2091
q6	196	171	136	136
q7	911	769	615	615
q8	9231	1322	1121	1121
q9	5163	4884	4889	4884
q10	6872	2323	1889	1889
q11	466	276	251	251
q12	347	359	214	214
q13	17789	3660	3115	3115
q14	238	233	218	218
q15	503	479	466	466
q16	632	633	596	596
q17	568	855	326	326
q18	7424	6715	6708	6708
q19	4309	959	535	535
q20	304	317	184	184
q21	2880	2376	2044	2044
q22	374	335	313	313
Total cold run time: 107112 ms
Total hot run time: 32512 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5616	5431	5379	5379
q2	234	333	244	244
q3	2253	2624	2364	2364
q4	1383	1803	1319	1319
q5	4292	4706	4805	4706
q6	173	163	129	129
q7	2057	1952	1762	1762
q8	2622	2820	2695	2695
q9	7266	7246	7323	7246
q10	2990	3205	2653	2653
q11	570	522	491	491
q12	682	742	645	645
q13	3510	3923	3310	3310
q14	282	307	270	270
q15	507	479	471	471
q16	661	697	637	637
q17	1224	1742	1270	1270
q18	7804	7588	7379	7379
q19	800	1166	1086	1086
q20	2016	2048	1896	1896
q21	5607	5087	5025	5025
q22	614	592	549	549
Total cold run time: 53163 ms
Total hot run time: 51526 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194739 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 071838c545ccfee59bd44a49740b9294d88fe120, data reload: false

query1	1300	944	941	941
query2	6364	2067	2073	2067
query3	10985	4538	4303	4303
query4	32779	23805	23189	23189
query5	3556	628	455	455
query6	285	213	197	197
query7	3996	488	303	303
query8	291	240	215	215
query9	9039	2578	2578	2578
query10	466	315	254	254
query11	17715	15601	15039	15039
query12	162	107	106	106
query13	1584	542	391	391
query14	10371	7705	7307	7307
query15	257	222	194	194
query16	7759	653	516	516
query17	1582	786	593	593
query18	2082	425	319	319
query19	221	192	172	172
query20	128	118	126	118
query21	209	125	106	106
query22	4487	4590	4261	4261
query23	34496	33848	33588	33588
query24	6616	2310	2413	2310
query25	486	454	393	393
query26	847	273	156	156
query27	2135	492	333	333
query28	5059	2437	2438	2437
query29	547	567	425	425
query30	211	190	155	155
query31	953	872	813	813
query32	70	58	85	58
query33	483	364	318	318
query34	775	883	531	531
query35	815	828	785	785
query36	1091	1045	974	974
query37	126	105	79	79
query38	4310	4260	4285	4260
query39	1496	1426	1444	1426
query40	213	118	103	103
query41	52	52	49	49
query42	130	112	104	104
query43	522	538	503	503
query44	1438	825	816	816
query45	189	180	175	175
query46	914	1080	677	677
query47	1873	1886	1871	1871
query48	392	410	329	329
query49	733	525	388	388
query50	686	697	415	415
query51	7053	7113	6942	6942
query52	103	103	102	102
query53	239	254	186	186
query54	506	520	419	419
query55	81	77	81	77
query56	265	266	269	266
query57	1260	1234	1152	1152
query58	258	254	254	254
query59	3100	3427	3064	3064
query60	294	277	271	271
query61	119	113	120	113
query62	824	770	683	683
query63	239	197	203	197
query64	3005	1016	677	677
query65	3239	3180	3141	3141
query66	786	397	350	350
query67	15985	15843	15423	15423
query68	6233	839	530	530
query69	499	312	266	266
query70	1176	1138	1130	1130
query71	392	318	258	258
query72	6010	3950	3847	3847
query73	648	782	355	355
query74	10105	8902	8782	8782
query75	3234	3162	2668	2668
query76	3182	1208	780	780
query77	507	397	277	277
query78	10075	10167	9301	9301
query79	3131	835	585	585
query80	699	545	441	441
query81	508	283	235	235
query82	226	152	118	118
query83	177	169	151	151
query84	238	88	80	80
query85	782	351	312	312
query86	391	306	313	306
query87	4418	4546	4488	4488
query88	5023	2135	2115	2115
query89	394	322	359	322
query90	1800	194	190	190
query91	136	140	112	112
query92	69	58	52	52
query93	2404	914	527	527
query94	657	397	307	307
query95	342	264	257	257
query96	485	603	273	273
query97	2776	2863	2843	2843
query98	229	208	186	186
query99	1282	1383	1233	1233
Total cold run time: 288860 ms
Total hot run time: 194739 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 071838c545ccfee59bd44a49740b9294d88fe120, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.43	0.43	0.38
query6	1.16	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.51	0.49
query10	0.55	0.56	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.60
query14	2.86	2.91	2.77
query15	0.90	0.83	0.83
query16	0.39	0.38	0.37
query17	1.07	1.06	1.02
query18	0.23	0.21	0.21
query19	1.92	1.83	2.04
query20	0.01	0.02	0.01
query21	15.38	0.95	0.59
query22	0.75	0.85	0.67
query23	15.21	1.36	0.56
query24	2.96	1.32	1.66
query25	0.14	0.15	0.17
query26	0.25	0.15	0.13
query27	0.08	0.06	0.05
query28	14.34	0.94	0.44
query29	12.57	3.95	3.33
query30	0.25	0.09	0.06
query31	2.83	0.62	0.39
query32	3.22	0.54	0.46
query33	2.99	2.99	3.04
query34	16.50	5.20	4.50
query35	4.51	4.52	4.57
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.13 s
Total hot run time: 31.14 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants