Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](sql) Wrong result of tosql for drop column with rollup #47153 #47205

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

wyxxxcat
Copy link
Contributor

pick: #47153

@wyxxxcat wyxxxcat requested a review from dataroaring as a code owner January 19, 2025 12:44
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40939 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 97c96b31c7ef8fc140a8ecfccb2f070a3b8e4d78, data reload: false

------ Round 1 ----------------------------------
q1	17590	7358	7209	7209
q2	2053	176	168	168
q3	10599	1096	1149	1096
q4	10548	733	680	680
q5	7749	2864	2824	2824
q6	237	149	146	146
q7	967	622	603	603
q8	9359	1903	2060	1903
q9	6554	6368	6388	6368
q10	7008	2297	2351	2297
q11	481	269	279	269
q12	432	234	233	233
q13	18219	3090	3173	3090
q14	244	212	213	212
q15	572	512	534	512
q16	685	626	638	626
q17	971	573	614	573
q18	7373	6656	6718	6656
q19	1396	1062	1036	1036
q20	470	203	205	203
q21	4090	3328	3242	3242
q22	1113	993	1003	993
Total cold run time: 108710 ms
Total hot run time: 40939 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7241	7239	7230	7230
q2	323	233	238	233
q3	2958	2920	2915	2915
q4	2055	1860	1825	1825
q5	5698	5781	5737	5737
q6	225	149	147	147
q7	2211	1854	1818	1818
q8	3379	3570	3535	3535
q9	8837	8852	8860	8852
q10	3589	3570	3547	3547
q11	623	486	495	486
q12	802	638	643	638
q13	9019	3168	3189	3168
q14	305	286	276	276
q15	562	538	536	536
q16	705	682	680	680
q17	1852	1616	1611	1611
q18	8282	7674	7575	7575
q19	1674	1623	1574	1574
q20	2102	1883	1864	1864
q21	5514	5255	5384	5255
q22	1136	1048	1049	1048
Total cold run time: 69092 ms
Total hot run time: 60550 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197979 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 97c96b31c7ef8fc140a8ecfccb2f070a3b8e4d78, data reload: false

query1	1305	934	884	884
query2	6479	2054	2096	2054
query3	10833	4252	4368	4252
query4	66719	29250	23543	23543
query5	4944	455	450	450
query6	423	181	172	172
query7	5640	305	303	303
query8	300	228	214	214
query9	9148	2677	2665	2665
query10	473	286	245	245
query11	17410	15284	15991	15284
query12	159	100	105	100
query13	1586	441	440	440
query14	11079	7608	7976	7608
query15	209	194	202	194
query16	7096	437	472	437
query17	1085	591	590	590
query18	1809	339	326	326
query19	224	167	170	167
query20	122	115	108	108
query21	214	103	102	102
query22	4788	4672	4540	4540
query23	35032	34228	34121	34121
query24	6288	2918	2915	2915
query25	525	438	422	422
query26	662	174	174	174
query27	1990	350	365	350
query28	4182	2488	2433	2433
query29	719	470	459	459
query30	246	165	168	165
query31	978	825	849	825
query32	66	60	56	56
query33	429	281	287	281
query34	921	517	512	512
query35	855	739	741	739
query36	1072	962	944	944
query37	120	80	73	73
query38	4059	4110	4024	4024
query39	1518	1473	1448	1448
query40	204	111	99	99
query41	47	49	46	46
query42	111	100	106	100
query43	543	490	486	486
query44	1223	823	832	823
query45	186	172	169	169
query46	1170	730	729	729
query47	1998	1899	1928	1899
query48	490	384	396	384
query49	745	392	388	388
query50	835	425	422	422
query51	7281	7400	7130	7130
query52	99	88	90	88
query53	258	179	182	179
query54	551	444	459	444
query55	76	77	74	74
query56	253	245	247	245
query57	1237	1135	1114	1114
query58	215	209	224	209
query59	3380	3124	2984	2984
query60	272	251	242	242
query61	105	116	113	113
query62	792	664	675	664
query63	217	194	190	190
query64	1359	663	635	635
query65	3281	3163	3206	3163
query66	630	309	308	308
query67	15978	15457	15414	15414
query68	3986	585	599	585
query69	438	258	260	258
query70	1197	1107	1117	1107
query71	359	264	257	257
query72	6395	3985	3967	3967
query73	749	341	339	339
query74	10484	9068	8915	8915
query75	3386	2641	2680	2641
query76	1895	1182	1147	1147
query77	480	272	280	272
query78	10698	9662	9634	9634
query79	1593	603	597	597
query80	891	428	421	421
query81	517	239	236	236
query82	1273	125	117	117
query83	163	144	148	144
query84	288	90	76	76
query85	872	286	297	286
query86	343	308	292	292
query87	4457	4370	4326	4326
query88	3860	2382	2364	2364
query89	413	287	288	287
query90	2030	184	179	179
query91	181	151	144	144
query92	67	50	52	50
query93	2000	544	542	542
query94	814	300	262	262
query95	355	257	250	250
query96	613	275	276	275
query97	3359	3157	3221	3157
query98	222	200	195	195
query99	1635	1309	1297	1297
Total cold run time: 321256 ms
Total hot run time: 197979 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.78 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 97c96b31c7ef8fc140a8ecfccb2f070a3b8e4d78, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.53	0.54	0.51
query6	1.13	0.73	0.74
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.56	0.51	0.49
query10	0.55	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.10
query13	0.60	0.59	0.60
query14	3.12	2.99	3.05
query15	0.89	0.83	0.82
query16	0.38	0.39	0.38
query17	1.04	1.03	1.06
query18	0.24	0.22	0.21
query19	1.98	1.86	1.94
query20	0.01	0.02	0.01
query21	15.37	0.60	0.60
query22	2.77	2.49	2.14
query23	16.92	1.18	0.82
query24	2.94	1.26	1.67
query25	0.28	0.16	0.19
query26	0.45	0.14	0.14
query27	0.04	0.04	0.04
query28	9.73	1.11	1.07
query29	12.60	3.30	3.28
query30	0.25	0.07	0.05
query31	2.88	0.39	0.38
query32	3.26	0.47	0.45
query33	2.98	3.06	3.00
query34	16.98	4.44	4.45
query35	4.54	4.56	4.53
query36	0.68	0.48	0.49
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.49 s
Total hot run time: 33.78 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants