add context to kafka supervisor for the kafka indexing task #3464
Conversation
| @@ -52,6 +54,7 @@ public KafkaSupervisorSpec( | |||
| @JsonProperty("dataSchema") DataSchema dataSchema, | |||
| @JsonProperty("tuningConfig") KafkaTuningConfig tuningConfig, | |||
| @JsonProperty("ioConfig") KafkaSupervisorIOConfig ioConfig, | |||
| @JsonProperty("context") Map<String, Object> context, | |||
There was a problem hiding this comment.
not sure if we should have docs for it because for existing tasks as well context is not mentioned anywhere in the docs. Can add if required.
There was a problem hiding this comment.
I don't see a reason why it is not documented ? IMHO if it has a added value it should be documented for both task and supervisor.
|
added documentation |
|
👍 |
1 similar comment
|
👍 |
|
This is just an overall comment, but the overriding of things like memory usage on a per-task basis actually breaks the encapsulation and control that the middle manager has over the resources used on its machine. That is, it is now possible for someone external from the system to set properties that effectively stop other people from being able to schedule and run other tasks. It looks like that capability was already introduced in #1604 so this isn't anything new. I'm fine with it going in, but I wanted to call out that this is something we are exposing now. |
|
@cheddar should I remove the documentation for it ? |
|
removed documentation of this feature because of @cheddar's comment |
|
merged as it had two 👍 |
Fixes #3463