fix review issue

apache · Jan 22, 2021 · b21ce4e · b21ce4e
1 parent bfbe4e9
commit b21ce4e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/go.mod b/go.mod
@@ -1,5 +1,7 @@
 module github.com/apache/dubbo-go
 
+go 1.15
+
 require (
 	github.com/NYTimes/gziphandler v1.1.1 // indirect
 	github.com/RoaringBitmap/roaring v0.5.5

diff --git a/metadata/service/remote/service.go b/metadata/service/remote/service.go
@@ -125,7 +125,7 @@ func (mts *MetadataService) PublishServiceDefinition(url *common.URL) error {
 					ServiceInterface: interfaceName,
 					Version:          url.GetParam(constant.VERSION_KEY, ""),
 					Group:            url.GetParam(constant.GROUP_KEY, constant.DUBBO),
-					Side:             url.GetParam(constant.SIDE_KEY, "provider"),
+					Side:             url.GetParam(constant.SIDE_KEY, constant.PROVIDER_PROTOCOL),
 				},
 			}
 			mts.delegateReport.StoreProviderMetadata(id, sd)
@@ -142,9 +142,8 @@ func (mts *MetadataService) PublishServiceDefinition(url *common.URL) error {
 			BaseMetadataIdentifier: identifier.BaseMetadataIdentifier{
 				ServiceInterface: interfaceName,
 				Version:          url.GetParam(constant.VERSION_KEY, ""),
-				// Group:            url.GetParam(constant.GROUP_KEY, constant.SERVICE_DISCOVERY_DEFAULT_GROUP),
-				Group: url.GetParam(constant.GROUP_KEY, constant.DUBBO),
-				Side:  url.GetParam(constant.SIDE_KEY, "consumer"),
+				Group:            url.GetParam(constant.GROUP_KEY, constant.DUBBO),
+				Side:             url.GetParam(constant.SIDE_KEY, "consumer"),
 			},
 		}
 		mts.delegateReport.StoreConsumerMetadata(id, params)