Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Optimize Trino connector property mapping system #1455

Closed
yuqi1129 opened this issue Jan 11, 2024 · 0 comments · Fixed by #1458
Closed

[Improvement] Optimize Trino connector property mapping system #1455

yuqi1129 opened this issue Jan 11, 2024 · 0 comments · Fixed by #1458
Assignees
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

Based on #1449 , we can optimize the current property mapping system to be more well-designed.

How should we improve?

No response

@yuqi1129 yuqi1129 added the improvement Improvements on everything label Jan 11, 2024
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Jan 16, 2024
yuqi1129 added a commit that referenced this issue Jan 18, 2024
…property (#1458)

### What changes were proposed in this pull request?

Use the new `PropertyConverter` in `catalog-common` to replace the old
one.

### Why are the changes needed?

We must provide a uniform property mapping system between Gravitino and
the query engine.
Fix: #1455 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Existing test can cover this change.
mchades pushed a commit to mchades/gravitino that referenced this issue Jan 19, 2024
…ngine property (apache#1458)

### What changes were proposed in this pull request?

Use the new `PropertyConverter` in `catalog-common` to replace the old
one.

### Why are the changes needed?

We must provide a uniform property mapping system between Gravitino and
the query engine.
Fix: apache#1455 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Existing test can cover this change.
mchades pushed a commit to mchades/gravitino that referenced this issue Jan 24, 2024
…ngine property (apache#1458)

### What changes were proposed in this pull request?

Use the new `PropertyConverter` in `catalog-common` to replace the old
one.

### Why are the changes needed?

We must provide a uniform property mapping system between Gravitino and
the query engine.
Fix: apache#1455 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Existing test can cover this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants