[#1455] improvement(all) Refactor catalog property mapping to engine property #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diqiu50
reviewed
Jan 17, 2024
catalogs/bundled-catalog/src/main/java/com/datastrato/catalog/property/PropertyConverter.java
Outdated
Show resolved
Hide resolved
catalogs/bundled-catalog/src/main/java/com/datastrato/catalog/property/PropertyConverter.java
Show resolved
Hide resolved
catalogs/bundled-catalog/src/main/java/com/datastrato/catalog/property/PropertyConverter.java
Show resolved
Hide resolved
| propertyEntry.decode(entry.getValue().toString()); | ||
| } | ||
| gravitinoProperties.put(gravitinoKey, entry.getValue()); | ||
| } |
There was a problem hiding this comment.
Should we throw an exception when the gravitinoKey is null?
There was a problem hiding this comment.
I would like the implementor to overwrite it and change the policy regarding null values.
There was a problem hiding this comment.
I will log the key with null value here.
...src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HiveMetadataAdapter.java
Outdated
Show resolved
Hide resolved
mchades
pushed a commit
to mchades/gravitino
that referenced
this pull request
Jan 19, 2024
…ngine property (apache#1458) ### What changes were proposed in this pull request? Use the new `PropertyConverter` in `catalog-common` to replace the old one. ### Why are the changes needed? We must provide a uniform property mapping system between Gravitino and the query engine. Fix: apache#1455 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? Existing test can cover this change.
mchades
pushed a commit
to mchades/gravitino
that referenced
this pull request
Jan 24, 2024
…ngine property (apache#1458) ### What changes were proposed in this pull request? Use the new `PropertyConverter` in `catalog-common` to replace the old one. ### Why are the changes needed? We must provide a uniform property mapping system between Gravitino and the query engine. Fix: apache#1455 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? Existing test can cover this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the new
PropertyConverterincatalog-commonto replace the old one.Why are the changes needed?
We must provide a uniform property mapping system between Gravitino and the query engine.
Fix: #1455
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Existing test can cover this change.