Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Optimize upload logs of IT container #3024

Closed
zhoukangcn opened this issue Apr 19, 2024 · 1 comment · Fixed by #3197
Closed

[Subtask] Optimize upload logs of IT container #3024

zhoukangcn opened this issue Apr 19, 2024 · 1 comment · Fixed by #3197
Assignees
@xiaozcy
Labels
subtask Subtasks of umbrella issue
Milestone
Gravitino June Re...

Comments

@zhoukangcn
Copy link
Contributor

Describe the subtask

in #2832 we upload log after Container start up, but we cannot upload log for IT cases.

Optimize implementation, able to package the entire log.

Parent issue

#2765
@zhoukangcn zhoukangcn added the subtask Subtasks of umbrella issue label Apr 19, 2024
@jerryshao jerryshao added this to the Gravitino June Release milestone Apr 24, 2024
@xiaozcy xiaozcy mentioned this issue Apr 28, 2024
Merged
@xiaozcy
Copy link
Contributor

xiaozcy commented Apr 28, 2024

This would be fixed by #3197

jerryshao pushed a commit that referenced this issue Apr 29, 2024
@xiaozcy @yuqi1129
[#3024] improvement(IT): close containers and upload container log af…
91c63f9 
…ter all tests are finished (#3197)

### What changes were proposed in this pull request?

close containers and upload container log after all tests are finished

### Why are the changes needed?

Fix: #3024 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

existing ITs

---------

Co-authored-by: zhanghan18 <[email protected]>
Co-authored-by: Qi Yu <[email protected]>
github-actions bot pushed a commit that referenced this issue Apr 29, 2024
@xiaozcy @yuqi1129 @web-flow
[#3024] improvement(IT): close containers and upload container log af…
641797d 
…ter all tests are finished (#3197)

### What changes were proposed in this pull request?

close containers and upload container log after all tests are finished

### Why are the changes needed?

Fix: #3024 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

existing ITs

---------

Co-authored-by: zhanghan18 <[email protected]>
Co-authored-by: Qi Yu <[email protected]>
@jerryshao jerryshao mentioned this issue Apr 29, 2024
Merged
yuqi1129 added a commit that referenced this issue Apr 30, 2024
@jerryshao @xiaozcy @yuqi1129
[#3024] improvement(IT): close containers and upload container log af…
3b460ce 
…ter all tests are finished (#3223)

### What changes were proposed in this pull request?

close containers and upload container log after all tests are finished

### Why are the changes needed?

Fix: #3024 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

existing ITs

Co-authored-by: XiaoZ <[email protected]>
Co-authored-by: zhanghan18 <[email protected]>
Co-authored-by: Qi Yu <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@xiaozcy @yuqi1129 @diqiu50
[apache#3024] improvement(IT): close containers and upload container …
b861e90 
…log after all tests are finished (apache#3197)

### What changes were proposed in this pull request?

close containers and upload container log after all tests are finished

### Why are the changes needed?

Fix: apache#3024 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

existing ITs

---------

Co-authored-by: zhanghan18 <[email protected]>
Co-authored-by: Qi Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaozcy xiaozcy

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
Gravitino June Release
4 participants
@jerryshao @zhoukangcn @yuqi1129 @xiaozcy