Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3024] improvement(IT): close containers and upload container log after all tests are finished #3223

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

close containers and upload container log after all tests are finished

Why are the changes needed?

Fix: #3024

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

existing ITs

…ter all tests are finished (#3197)

### What changes were proposed in this pull request?

close containers and upload container log after all tests are finished

### Why are the changes needed?

Fix: #3024 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

existing ITs

---------

Co-authored-by: zhanghan18 <[email protected]>
Co-authored-by: Qi Yu <[email protected]>
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch upload log Always upload container log labels Apr 29, 2024
@jerryshao
Copy link
Contributor Author

@yuqi1129 would you please help to merge this PR?

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit 3b460ce into branch-0.5 Apr 30, 2024
20 checks passed
@yuqi1129 yuqi1129 deleted the cherry-pick-branch-0.5-91c63f963840ca3a807bb79c44e72f4de1370f4f branch April 30, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch upload log Always upload container log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants