Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Log4jLoggerFactory package conflict when running on spark 3.3 #3320

Closed
Tracked by #1574
FANNG1 opened this issue May 10, 2024 · 0 comments · Fixed by #3318
Closed
Tracked by #1574

[Bug report] Log4jLoggerFactory package conflict when running on spark 3.3 #3320

FANNG1 opened this issue May 10, 2024 · 0 comments · Fixed by #3318
Assignees
Labels
bug Something isn't working

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented May 10, 2024

Version

main branch

Describe what's wrong

run spark connector with spark 3.3 failed because of Log4jLoggerFactory package conflict, the slf4j packaged in Gravitino-java-runtime is 2.0.9, while spark 3.3 relies on 1.7.32

Error message and/or stacktrace

java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found

How to reproduce

run with spark 3.3

Additional context

No response

@FANNG1 FANNG1 added the bug Something isn't working label May 10, 2024
jerryshao pushed a commit that referenced this issue May 10, 2024
### What changes were proposed in this pull request?
shadow slf4j for client-java-runtime and spark-connector-runtime 

### Why are the changes needed?
some systems like spark 3.3 need low version log4j, will encounter the
conflict bug:

```
java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found
```

fix: #3320 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
existing tests
github-actions bot pushed a commit that referenced this issue May 10, 2024
### What changes were proposed in this pull request?
shadow slf4j for client-java-runtime and spark-connector-runtime 

### Why are the changes needed?
some systems like spark 3.3 need low version log4j, will encounter the
conflict bug:

```
java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found
```

fix: #3320 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
existing tests
FANNG1 added a commit that referenced this issue May 10, 2024
### What changes were proposed in this pull request?
shadow slf4j for client-java-runtime and spark-connector-runtime 

### Why are the changes needed?
some systems like spark 3.3 need low version log4j, will encounter the
conflict bug:

```
java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found
```

fix: #3320 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
existing tests

Co-authored-by: FANNG <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
…he#3318)

### What changes were proposed in this pull request?
shadow slf4j for client-java-runtime and spark-connector-runtime 

### Why are the changes needed?
some systems like spark 3.3 need low version log4j, will encounter the
conflict bug:

```
java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found
```

fix: apache#3320 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants