Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3320] fix(client): shadow slf4j for client-java-runtime #3331

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

shadow slf4j for client-java-runtime and spark-connector-runtime

Why are the changes needed?

some systems like spark 3.3 need low version log4j, will encounter the conflict bug:

java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found

fix: #3320

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

### What changes were proposed in this pull request?
shadow slf4j for client-java-runtime and spark-connector-runtime 

### Why are the changes needed?
some systems like spark 3.3 need low version log4j, will encounter the
conflict bug:

```
java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found
```

fix: #3320 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
existing tests
@FANNG1 FANNG1 merged commit abba6ef into branch-0.5 May 10, 2024
22 checks passed
@jerryshao jerryshao deleted the cherry-pick-branch-0.5-4307d5f4f3fdab29fa2728ec2b7b344c44249d5c branch May 14, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants