[#6076] improve(CLI): Support model pre event to Gravitino server #6250

Abyss-lord · 2025-01-15T08:23:00Z

What changes were proposed in this pull request?

Support model pre event to Gravitino server, based on #6129 , Both synchronize Dispatcher changes with each other

https://docs.google.com/document/d/1_aVCd_tKiEebpzp9tg07Lzdk1j6EalNn8YOIdRn-3z4/edit?tab=t.0#heading=h.k85t4bueowc5

PreEvent

PreEvent	OperationType	ModelCatalog
`RegisterModelPreEvent`	`REGISTER_MODEL`	`registerModel`
`GetModelPreEvent`	`LOAD_MODEL`	`getModel`
`DeleteModelEvent`	`Delete_MODEL`	`deleteModel`
`ListModelPreEvent`	`LIST_MODEL`	`listModels`
`LinkModelVersionPreEvent`	`LINK_MODEL_VERSION`	`linkModelVersion`
`GetModelVersionPreEvent`	`GET_MODEL_VERSION`	`getModelVersion`
`DeleteModelVersionPreEvent`	`Delete_MODEL_VERSION`	`deleteModelVersion`
`ListModelVersionsPreEvent`	`LIST_MODEL_VERSIONS`	`listModelVersions`

ModelEventDispatcher

Why are the changes needed?

Fix: #6076

Does this PR introduce any user-facing change?

No

How was this patch tested?

Model Event

testRegisterModelEvent
testGetModelEvent
testDeleteExistsModelEvent
testDeleteNotExistsModelEvent
testListModelEvent

Model Version Event

testLinkModelVersionEvent
testGetModelVersionEventViaVersion
testGetModelVersionEventViaAlias
testDeleteModelVersionEventViaVersion
testDeleteModelVersionEventViaAlias
testDeleteModelVersionEventViaVersionNotExists
testListModelVersionsEvent

Abyss-lord · 2025-01-18T03:35:08Z

@FANNG1 @xunliu @orenccl could you please review this PR when you have time? I’d really appreciate your feedback.

Support model event to Gravitino server. Add list, get, create and delete events to both model and model version.

Fix some class comments.

Fix some error.

Fix some error and add ModelEventDispatcher to Gravitino server.

…t been refactored rename drop event and operation type.

Support model pre event to Gravitino server. [apache#6067] improve(CLI): Support model pre event to Gravitino server add model version related pre event to Gravitino server. [apache#6067] improve(CLI): Support model pre event to Gravitino server add preEvent support for ModelEventDispatcher. [apache#6067] improve(CLI): Support model pre event to Gravitino server add test cases.

… server fix some issues.

… server Remove Model Event.

Abyss-lord · 2025-02-19T03:47:45Z

@FANNG1 should we add ModelEventDispatcher to the Context in this pr? Or wait until all the events are complete？

core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java

core/src/main/java/org/apache/gravitino/listener/api/info/ModelInfo.java

FANNG1 · 2025-02-24T14:34:19Z

@Abyss-lord sorry for the delay, could you check the comments and add document in https://github.com/apache/gravitino/blob/main/docs/gravitino-server-config.md?plain=1#L129 ?

tengqm · 2025-02-25T01:06:30Z

Just took a quick glance over the eventing code base ... and I got a question.
Given that we want to emit events for every operation on every entity, the current case-by-case implementation is problematic. It doesn't scale well.

Driven by this observation, I'm thinking if this can be drastically simplified. For example, we can use a handful of abstractions rather than tens of them to model events. Maybe we simply don't need all the fields in every event? I mean we can have a gemeroc link field pointing to the URI of the relevant object?

FANNG1 · 2025-02-25T02:08:02Z

Just took a quick glance over the eventing code base ... and I got a question. Given that we want to emit events for every operation on every entity, the current case-by-case implementation is problematic. It doesn't scale well.

Driven by this observation, I'm thinking if this can be drastically simplified. For example, we can use a handful of abstractions rather than tens of them to model events. Maybe we simply don't need all the fields in every event? I mean we can have a gemeroc link field pointing to the URI of the relevant object?

Yes, adding events one by one for all operations is painful. This is a trade-off, in this one-by-one way, the user could handle the event more flexibly, and if do with some general abstraction, we may lose some specific information in the event, any suggestions?

tengqm · 2025-02-25T02:32:45Z

if do with some general abstraction, we may lose some specific information in the event, any suggestions?

It all depends on the use case, IMHO. We can always add "specific information" later on when needed. At this moment, we may want to rethink whether we really want to dump all details into events. If the event is about to be triggered for all requests and responses, we can have a nice abstraction, which is just to dump the request/response body. It is gonna be a heavy burden for such a detailed dump, especially for LIST operations.

core/src/main/java/org/apache/gravitino/listener/api/info/ModelInfo.java

FANNG1 · 2025-02-26T03:27:25Z

Totally, please try to avoid doing another IO to get model or model version information for the event, using the parameter in the request seems enough.

… roles is bound to many metadata. (apache#6455) ### What changes were proposed in this pull request? fix issue apache#6238 improve performance when a single role is bound to many metadata. ### Why are the changes needed? Use batch queries when getting role securable object full names instead of loop queries to get each securable object full name. Fix: apache#6238 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests and integration tests have all passed, this feature has been running internally at Xiaomi for two weeks. Co-authored-by: luoxin5 <[email protected]>

…o configure gvfs-fuse. (apache#6465) ### What changes were proposed in this pull request? Fix the bug of using a relative path to configure gvfs-fuse. ### Why are the changes needed? Fix: apache#6464 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? Manually test

…FSFileSystemProvider` problem (apache#6463) ### What changes were proposed in this pull request? In the current code base, we need to add `catalog-hadoop` to make GVFS client works or class `HDFSFileSystemProvider` and `LocalFileSystemProvider` can't be found. ### Why are the changes needed? It's a bug. Fix: apache#6462 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs, UTs and test locally.

### What changes were proposed in this pull request? This pr removes outdated tips from `web-ui.md` because, as indicated in the subsequent text, operations such as creating or modifying schemas, tables, or filesets can now be performed through the web UI. ### Why are the changes needed? Remove outdated tips from `web-ui.md` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? manual review

…on parameters through environment variables (apache#6458) ### What changes were proposed in this pull request? Add the environment variables `GRAVITINO_JDBC_USER`, `GRAVITINO_JDBC_PASSWORD`, and `GRAVITINO_S3_ENDPOINT` to the `rewrite_config.py`, so database user and password can be set by the user in a container environment as well as a custom S3 endpoint. ### Why are the changes needed? Currently, JDBC user and PW are hardcoded to `iceberg` and cannot be changed when using the container images. One workaround is including the values in the JDBC connection string, but this neither elegant nor in line with how containers commonly handle this issue. Additionally, it wasn't possible to set the value of `gravitino.iceberg-rest.s3-endpoint` in a container environment, which can be useful in a variety of situations when using a provider other than AWS. ### Does this PR introduce _any_ user-facing change? Added the three aforementioned two environment variables that can be used by the user. ### How was this patch tested? Was tested locally only, since this is a minimal change.

### What changes were proposed in this pull request? fix uri title of version detail ### Why are the changes needed? N/A Fix: apache#6478 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? manually

…che#6405) ### What changes were proposed in this pull request? Add Readme document of gvfs-fuse ### Why are the changes needed? Fix: apache#6404 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No

…mand in Gravitino CLI to command (apache#6535) ### What changes were proposed in this pull request? Move check for enable and disable command in Gravitino CLI to command ### Why are the changes needed? Fix: apache#6136 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? local test ```bash gcli metalake update -m demo_metalake --disable -i demo_metalake has been disabled. gcli metalake update -m demo_metalake --enable -i demo_metalake has been enabled. gcli metalake update -m demo_metalake --enable --disable -i Unable to us --enable and --disable at the same time gcli metalake update -m demo_metalake --enable --all -i demo_metalake has been enabled. and all catalogs in this metalake have been enabled. gcli catalog update -m demo_metalake --name Hive_catalog --disable -i demo_metalake.Hive_catalog has been disabled. gcli catalog update -m demo_metalake --name Hive_catalog --enable -i demo_metalake.Hive_catalog has been enabled. gcli catalog update -m demo_metalake --name Hive_catalog --enable --disable -i Unable to us --enable and --disable at the same time ``` --------- Co-authored-by: Justin Mclean <[email protected]>

Bumps [dorny/paths-filter](https://github.com/dorny/paths-filter) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dorny/paths-filter/releases">dorny/paths-filter's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update README.md: added real world usage example by <a href="https://github.com/iamtodor"><code>@iamtodor</code></a> in <a href="https://redirect.github.com/dorny/paths-filter/pull/178">dorny/paths-filter#178</a></li> <li>Update Node.js to version 20 by <a href="https://github.com/danielhjacobs"><code>@danielhjacobs</code></a> in <a href="https://redirect.github.com/dorny/paths-filter/pull/206">dorny/paths-filter#206</a></li> <li>Update to nodejs 20 by <a href="https://github.com/dorny"><code>@dorny</code></a> in <a href="https://redirect.github.com/dorny/paths-filter/pull/210">dorny/paths-filter#210</a></li> <li>chore(deps): bump checkout action to v4 and use setup-node to setup node and cache npm deps by <a href="https://github.com/chenrui333"><code>@chenrui333</code></a> in <a href="https://redirect.github.com/dorny/paths-filter/pull/211">dorny/paths-filter#211</a></li> <li>Update all dependencies by <a href="https://github.com/dorny"><code>@dorny</code></a> in <a href="https://redirect.github.com/dorny/paths-filter/pull/215">dorny/paths-filter#215</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/iamtodor"><code>@iamtodor</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/paths-filter/pull/178">dorny/paths-filter#178</a></li> <li><a href="https://github.com/danielhjacobs"><code>@danielhjacobs</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/paths-filter/pull/206">dorny/paths-filter#206</a></li> <li><a href="https://github.com/chenrui333"><code>@chenrui333</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/paths-filter/pull/211">dorny/paths-filter#211</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/dorny/paths-filter/compare/v2.11.1...v3.0.0">https://github.com/dorny/paths-filter/compare/v2.11.1...v3.0.0</a></p> <h2>v2.11.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/167">Update <code>@actions/core</code> to v1.10.0 - Fixes warning about deprecated set-output</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/168">Document need for pull-requests: read permission</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/164">Updating to actions/checkout@v3</a></li> </ul> <h2>v2.11.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/157">Set list-files input parameter as not required</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/161">Update Node.js</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/162">Fix incorrect handling of Unicode characters in exec()</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/163">Use Octokit pagination</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/160">Updates real world links</a></li> </ul> <h2>v2.10.2</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/91">Fix getLocalRef() returns wrong ref</a></li> </ul> <h2>v2.10.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/85">Improve robustness of change detection</a></li> </ul> <h2>v2.10.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/82">Add ref input parameter</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/83">Fix change detection in PR when <code>pullRequest.changed_files</code> is incorrect</a></li> </ul> <h2>v2.9.3</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/78">Fix change detection when base is a tag</a></li> </ul> <h2>v2.9.2</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/75">Fix fetching git history</a></li> </ul> <h2>v2.9.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/74">Fix fetching git history + fallback to unshallow repo</a></li> </ul> <h2>v2.9.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/68">Add list-files: csv format</a></li> </ul> <h2>v2.8.0</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dorny/paths-filter/blob/master/CHANGELOG.md">dorny/paths-filter's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v3.0.2</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/224">Add config parameter for predicate quantifier</a></li> </ul> <h2>v3.0.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/133">Compare base and ref when token is empty</a></li> </ul> <h2>v3.0.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/210">Update to Node.js 20</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/215">Update all dependencies</a></li> </ul> <h2>v2.11.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/167">Update <code>@actions/core</code> to v1.10.0 - Fixes warning about deprecated set-output</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/168">Document need for pull-requests: read permission</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/164">Updating to actions/checkout@v3</a></li> </ul> <h2>v2.11.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/157">Set list-files input parameter as not required</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/161">Update Node.js</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/162">Fix incorrect handling of Unicode characters in exec()</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/163">Use Octokit pagination</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/160">Updates real world links</a></li> </ul> <h2>v2.10.2</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/91">Fix getLocalRef() returns wrong ref</a></li> </ul> <h2>v2.10.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/85">Improve robustness of change detection</a></li> </ul> <h2>v2.10.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/82">Add ref input parameter</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/83">Fix change detection in PR when pullRequest.changed_files is incorrect</a></li> </ul> <h2>v2.9.3</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/78">Fix change detection when base is a tag</a></li> </ul> <h2>v2.9.2</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/75">Fix fetching git history</a></li> </ul> <h2>v2.9.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/74">Fix fetching git history + fallback to unshallow repo</a></li> </ul> <h2>v2.9.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/68">Add list-files: csv format</a></li> </ul> <h2>v2.8.0</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/65">Add count output variable</a></li> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/61">Fix log grouping of changes</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dorny/paths-filter/commit/de90cc6fb38fc0963ad72b210f1f284cd68cea36"><code>de90cc6</code></a> Update dist and CHANGELOG for v3.0.2</li> <li><a href="https://github.com/dorny/paths-filter/commit/cf89abdbaede7b5bcbc8e105da2aaa39fd84b997"><code>cf89abd</code></a> Merge pull request <a href="https://redirect.github.com/dorny/paths-filter/issues/224">#224</a> from petermetz/feat-filter-predicate-quantifier</li> <li><a href="https://github.com/dorny/paths-filter/commit/f90d5265d6f3c389e3bd0288de3cafc818e26a0f"><code>f90d526</code></a> feat: add config parameter for predicate quantifier</li> <li><a href="https://github.com/dorny/paths-filter/commit/ebc4d7e9ebcb0b1eb21480bb8f43113e996ac77a"><code>ebc4d7e</code></a> Update CHANGELOG for v3.0.1</li> <li><a href="https://github.com/dorny/paths-filter/commit/45f16f1875754d8424ea8a6a134c81fd56637525"><code>45f16f1</code></a> Merge pull request <a href="https://redirect.github.com/dorny/paths-filter/issues/133">#133</a> from frouioui/main</li> <li><a href="https://github.com/dorny/paths-filter/commit/5da0e4c086f427696edbc188de7cc487edc8befd"><code>5da0e4c</code></a> Merge branch 'master'</li> <li><a href="https://github.com/dorny/paths-filter/commit/1441771bbfdd59dcd748680ee64ebd8faab1a242"><code>1441771</code></a> Update README.md</li> <li><a href="https://github.com/dorny/paths-filter/commit/0bc4621a3135347011ad047f9ecf449bf72ce2bd"><code>0bc4621</code></a> Bump major version to v3</li> <li><a href="https://github.com/dorny/paths-filter/commit/7267a8516b6f92bdb098633497bad573efdbf271"><code>7267a85</code></a> Update CHANGELOG for v2.12.0</li> <li><a href="https://github.com/dorny/paths-filter/commit/e36f1124bf7d4849984518d6d3c52cceead221f4"><code>e36f112</code></a> Merge pull request <a href="https://redirect.github.com/dorny/paths-filter/issues/215">#215</a> from dorny/update-dependencies</li> <li>Additional commits viewable in <a href="https://github.com/dorny/paths-filter/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dorny/paths-filter&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

### What changes were proposed in this pull request? Use standard disclaimer text and file name. ### Why are the changes needed? To comply with ASF policy. Fix: #(issue) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A

…from 1.0.9 to 1.0.10 (apache#6550)" (apache#6564) ### What changes were proposed in this pull request? This reverts commit 54a5371. ### Why are the changes needed? Seems like the new version cannot be used by Apache Gravitino https://github.com/apache/gravitino/actions/runs/13558713734 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing test.

…iroment (apache#6432) ### What changes were proposed in this pull request? I'm not sure the root reason, seems MYSQL JDBC driver was not loaded automatically in some condition, in this PR, load Mysql driver explicitly. ### Why are the changes needed? Fix: apache#6392 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? test in local machine. --------- Co-authored-by: Qi Yu <[email protected]>

…TAINERS.md (apache#6572) Update unknowntpo's organization due to career change in MAINTAINERS.md.  ### What changes were proposed in this pull request? Update unknowntpo's organization due to career change in MAINTAINERS.md. ### Why are the changes needed? Career change. Fix: #(issue) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? None.

…ol (apache#6470) ### What changes were proposed in this pull request? Support metrics for JDBC backend connect pool : 1. activeConnectionCount 2. idleConnectionCount 3. maxConnectionCount ### Why are the changes needed? Support metrics for JDBC connection pool Fix: apache#6468 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need to test --------- Co-authored-by: teo <[email protected]> Co-authored-by: teo <[email protected]>

Bumps [qs](https://github.com/ljharb/qs) and [@types/qs](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/qs). These dependencies needed to be updated together. Updates `qs` from 6.12.2 to 6.14.0 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/qs/blob/main/CHANGELOG.md">qs's changelog</a>.</em></p> <blockquote> <h2><strong>6.14.0</strong></h2> <ul> <li>[New] <code>parse</code>: add <code>throwOnParameterLimitExceeded</code> option (<a href="https://redirect.github.com/ljharb/qs/issues/517">#517</a>)</li> <li>[Refactor] <code>parse</code>: use <code>utils.combine</code> more</li> <li>[patch] <code>parse</code>: add explicit <code>throwOnLimitExceeded</code> default</li> <li>[actions] use shared action; re-add finishers</li> <li>[meta] Fix changelog formatting bug</li> <li>[Deps] update <code>side-channel</code></li> <li>[Dev Deps] update <code>es-value-fixtures</code>, <code>has-bigints</code>, <code>has-proto</code>, <code>has-symbols</code></li> <li>[Tests] increase coverage</li> </ul> <h2><strong>6.13.1</strong></h2> <ul> <li>[Fix] <code>stringify</code>: avoid a crash when a <code>filter</code> key is <code>null</code></li> <li>[Fix] <code>utils.merge</code>: functions should not be stringified into keys</li> <li>[Fix] <code>parse</code>: avoid a crash with interpretNumericEntities: true, comma: true, and iso charset</li> <li>[Fix] <code>stringify</code>: ensure a non-string <code>filter</code> does not crash</li> <li>[Refactor] use <code>__proto__</code> syntax instead of <code>Object.create</code> for null objects</li> <li>[Refactor] misc cleanup</li> <li>[Tests] <code>utils.merge</code>: add some coverage</li> <li>[Tests] fix a test case</li> <li>[actions] split out node 10-20, and 20+</li> <li>[Dev Deps] update <code>es-value-fixtures</code>, <code>mock-property</code>, <code>object-inspect</code>, <code>tape</code></li> </ul> <h2><strong>6.13.0</strong></h2> <ul> <li>[New] <code>parse</code>: add <code>strictDepth</code> option (<a href="https://redirect.github.com/ljharb/qs/issues/511">#511</a>)</li> <li>[Tests] use <code>npm audit</code> instead of <code>aud</code></li> </ul> <h2><strong>6.12.3</strong></h2> <ul> <li>[Fix] <code>parse</code>: properly account for <code>strictNullHandling</code> when <code>allowEmptyArrays</code></li> <li>[meta] fix changelog indentation</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ljharb/qs/commit/32dcc637f90be175c0d4617b429263115a87e3a8"><code>32dcc63</code></a> v6.14.0</li> <li><a href="https://github.com/ljharb/qs/commit/4ec582b07a411f49b3192ea92562e2ad503a4dc0"><code>4ec582b</code></a> [Dev Deps] update <code>es-value-fixtures</code>, <code>has-bigints</code></li> <li><a href="https://github.com/ljharb/qs/commit/a240c52c7c48d3ead6bd77c5bc3b1275bab252fc"><code>a240c52</code></a> [Tests] increase coverage</li> <li><a href="https://github.com/ljharb/qs/commit/25956a73e8cf56d445b0972cc3d9d16eb0958435"><code>25956a7</code></a> [Refactor] <code>parse</code>: use <code>utils.combine</code> more</li> <li><a href="https://github.com/ljharb/qs/commit/b189ed49c8dfe5b41afe6cecabdaa562de56764b"><code>b189ed4</code></a> [patch] <code>parse</code>: add explicit <code>throwOnLimitExceeded</code> default</li> <li><a href="https://github.com/ljharb/qs/commit/1d590de5eb325a6ea332812b260c024e6a58ab8c"><code>1d590de</code></a> [actions] simplify finisher</li> <li><a href="https://github.com/ljharb/qs/commit/6cd60a59aae428123d45810996f4ac6b2c4e5c52"><code>6cd60a5</code></a> [actions] use shared action</li> <li><a href="https://github.com/ljharb/qs/commit/89edfd25f9598b5ccfe7eec9c4c184d5e8854ee2"><code>89edfd2</code></a> [Deps] update <code>side-channel</code></li> <li><a href="https://github.com/ljharb/qs/commit/e26e7a8946b507c9445e08de04ee1b95c8eb6693"><code>e26e7a8</code></a> [Dev Deps] update <code>has-proto</code>, <code>has-symbols</code></li> <li><a href="https://github.com/ljharb/qs/commit/51fdc98d72cbfb33f5bab9da1eb8d511b3160249"><code>51fdc98</code></a> [actions] re-add finishers</li> <li>Additional commits viewable in <a href="https://github.com/ljharb/qs/compare/v6.12.2...v6.14.0">compare view</a></li> </ul> </details> <br /> Updates `@types/qs` from 6.9.15 to 6.9.18 <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/qs">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…e#6555) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.39 to 8.5.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p> <blockquote> <h2>8.5.3</h2> <ul> <li>Added more details to <code>Unknown word</code> error (by <a href="https://github.com/hiepxanh"><code>@hiepxanh</code></a>).</li> <li>Fixed types (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> <li>Fixed docs (by <a href="https://github.com/catnipan"><code>@catnipan</code></a>).</li> </ul> <h2>8.5.2</h2> <ul> <li>Fixed end position of rules with semicolon (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.5.1</h2> <ul> <li>Fixed backwards compatibility for complex cases (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.5 “Duke Alloces”</h2>  <p>PostCSS 8.5 brought API to work better with non-CSS sources like HTML, Vue.js/Svelte sources or CSS-in-JS.</p> <p><a href="https://github.com/romainmenke"><code>@romainmenke</code></a> during <a href="https://redirect.github.com/postcss/postcss/issues/1995">his work</a> on <a href="https://stylelint.io">Stylelint</a> added <code>Input#document</code> in additional to <code>Input#css</code>.</p> <pre lang="js"><code>root.source.input.document //=> "<p>Hello</p> // <style> // p { // color: green; // } // </style>" root.source.input.css //=> "p { // color: green; // }" <p></code></pre></p> <h2>Thanks to Sponsors</h2> <p>This release was possible thanks to our community.</p> <p>If your company wants to support the sustainability of front-end infrastructure or wants to give some love to PostCSS, you can join our supporters by:</p> <ul> <li><a href="https://tidelift.com/"><strong>Tidelift</strong></a> with a Spotify-like subscription model supporting all projects from your lock file.</li> <li>Direct donations at <a href="https://github.com/sponsors/ai"><strong>GitHub Sponsors</strong></a> or <a href="https://opencollective.com/postcss#section-contributors"><strong>Open Collective</strong></a>.</li> </ul> <h2>8.4.49</h2> <ul> <li>Fixed custom syntax without <code>source.offset</code> (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.4.48</h2> <ul> <li>Fixed position calculation in error/warnings methods (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.4.47</h2> <ul> <li>Removed debug code.</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/blob/main/CHANGELOG.md">postcss's changelog</a>.</em></p> <blockquote> <h2>8.5.3</h2> <ul> <li>Added more details to <code>Unknown word</code> error (by <a href="https://github.com/hiepxanh"><code>@hiepxanh</code></a>).</li> <li>Fixed types (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> <li>Fixed docs (by <a href="https://github.com/catnipan"><code>@catnipan</code></a>).</li> </ul> <h2>8.5.2</h2> <ul> <li>Fixed end position of rules with semicolon (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.5.1</h2> <ul> <li>Fixed backwards compatibility for complex cases (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.5 “Duke Alloces”</h2> <ul> <li>Added <code>Input#document</code> for sources like CSS-in-JS or HTML (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.4.49</h2> <ul> <li>Fixed custom syntax without <code>source.offset</code> (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.4.48</h2> <ul> <li>Fixed position calculation in error/warnings methods (by <a href="https://github.com/romainmenke"><code>@romainmenke</code></a>).</li> </ul> <h2>8.4.47</h2> <ul> <li>Removed debug code.</li> </ul> <h2>8.4.46</h2> <ul> <li>Fixed <code>Cannot read properties of undefined (reading 'before')</code>.</li> </ul> <h2>8.4.45</h2> <ul> <li>Removed unnecessary fix which could lead to infinite loop.</li> </ul> <h2>8.4.44</h2> <ul> <li>Another way to fix <code>markClean is not a function</code> error.</li> </ul> <h2>8.4.43</h2> <ul> <li>Fixed <code>markClean is not a function</code> error.</li> </ul> <h2>8.4.42</h2> <ul> <li>Fixed CSS syntax error on long minified files (by <a href="https://github.com/varpstar"><code>@varpstar</code></a>).</li> </ul> <h2>8.4.41</h2> <ul> <li>Fixed types (by <a href="https://github.com/nex3"><code>@nex3</code></a> and <a href="https://github.com/querkmachine"><code>@querkmachine</code></a>).</li> <li>Cleaned up RegExps (by <a href="https://github.com/bluwy"><code>@bluwy</code></a>).</li> </ul> <h2>8.4.40</h2> <ul> <li>Moved to getter/setter in nodes types to help Sass team (by <a href="https://github.com/nex3"><code>@nex3</code></a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/postcss/postcss/commit/22c309d32924e1eeb33c80a6a50b7ba8a43a1832"><code>22c309d</code></a> Release 8.5.3 version</li> <li><a href="https://github.com/postcss/postcss/commit/a2b594f7826fc8e0ce2d35adcd205fde04f1134f"><code>a2b594f</code></a> Update ESLint config</li> <li><a href="https://github.com/postcss/postcss/commit/8232ba02575fca41b14c4e2b377adc68880846fa"><code>8232ba0</code></a> Fix tests</li> <li><a href="https://github.com/postcss/postcss/commit/5082831b842eb40f8d298e5e0ab041755a04a58b"><code>5082831</code></a> Fix text</li> <li><a href="https://github.com/postcss/postcss/commit/4fdb54b5ce67e038ed8d1aa79752d6f6072d0736"><code>4fdb54b</code></a> update: parser.js to clarify error message</li> <li><a href="https://github.com/postcss/postcss/commit/06006ecb04cae0ddb62c6a85f15d1068c544d861"><code>06006ec</code></a> AtRule can be empty</li> <li><a href="https://github.com/postcss/postcss/commit/755f08f8dbdbc001906b10db3b262948f8491d82"><code>755f08f</code></a> fix typo: them -> then (<a href="https://redirect.github.com/postcss/postcss/issues/2016">#2016</a>)</li> <li><a href="https://github.com/postcss/postcss/commit/692fcde123dbf51c7b1a178370d3e8c6fe7feeee"><code>692fcde</code></a> Release 8.5.2 version</li> <li><a href="https://github.com/postcss/postcss/commit/b70e98f624537063d3094644b04f41bd2863bb65"><code>b70e98f</code></a> Update dependencies</li> <li><a href="https://github.com/postcss/postcss/commit/ba587e32fd51004d334421013f311017f00e5420"><code>ba587e3</code></a> Fix end position of rules with <code>ownSemicon</code> (<a href="https://redirect.github.com/postcss/postcss/issues/2012">#2012</a>)</li> <li>Additional commits viewable in <a href="https://github.com/postcss/postcss/compare/8.4.39...8.5.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=postcss&package-manager=npm_and_yarn&previous-version=8.4.39&new-version=8.5.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…st (apache#6567) ### What changes were proposed in this pull request? Fix ci issue by default sleep ### Why are the changes needed? Need a sleep time for render latest data Only verifyShowDataItemInList and verifyNoDataItemInList Fix: apache#6459 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? repeat run ci test case

…to the corresponding implementation to minimize tree lock range. (apache#2873) ### What changes were proposed in this pull request? Modify the rest API and move the tree lock to the core module. ### Why are the changes needed? The rest API should not be locked entirely by a tree lock. Fix: apache#2780 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? N/A. --------- Co-authored-by: Jerry Shao <[email protected]>

… server Fix some bugs.

tengqm · 2025-03-02T08:28:04Z

.github/dependabot.yml

+  - package-ecosystem: "npm"
+    directory: "/web/web"
+    schedule:
+      interval: "weekly"


What's this?

Are you rebasing your branch over main?

… server Fix some bugs.

Abyss-lord · 2025-03-02T08:39:58Z

@FANNG1 @tengqm I’ve finished updating the code and design doc. Please take a look at the PR again when you have time.

Abyss-lord · 2025-03-03T02:02:36Z

@FANNG1 Plz approve the workflows.

Abyss-lord · 2025-03-03T03:02:08Z

@FANNG1 It was my mistake that caused the problem？Why do so many workflows fail？

FANNG1 · 2025-03-03T03:42:17Z

@FANNG1 It was my mistake that caused the problem？Why do so many workflows fail？

seems not related, the docker container is not started successfully.

tengqm · 2025-03-03T04:49:49Z

core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java

+        new RegisterModelPreEvent(PrincipalUtils.getCurrentUserName(), ident, registerRequest));
+    try {
+      Model model = dispatcher.registerModel(ident, comment, properties);
+      // TODO: ModelEvent


In my view, this is not a good practice for raising PRs.
Each PR is supposed to be:

small, e.g. <500 lines of code changes;

self-contained, with all irrelevant changes stripped off;

good enough, i.e. not half-baked;

easy to roll-back, if some bugs are introduced unfortunately

It is perfectly okay to raise 10+ smaller PRs a day, because we know that small steps forward make big progress.

For this specific PR, I'd suggest we implement Model Event dispatcher with test cases;
then we raise PRs for each specific events, each with its own test cases.

WDYT?

core/src/main/java/org/apache/gravitino/listener/api/event/RegisterModelPreEvent.java

core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java

docs/gravitino-server-config.md

… server Fix some bugs.

Abyss-lord · 2025-03-03T09:52:29Z

@FANNG1 I’ve finished updating the code. Please take a look at the PR again when you have time.

Abyss-lord changed the title ~~[#6067] improve(CLI): Support model pre event to Gravitino server~~ [#6076] improve(CLI): Support model pre event to Gravitino server Jan 16, 2025

Abyss-lord force-pushed the model-pre-event branch from 416d3b4 to 3f7f61c Compare February 13, 2025 03:41

Abyss-lord mentioned this pull request Feb 13, 2025

[#6078] feat(core): Support model event to Gravitino server #6129

Closed

Abyss-lord added 8 commits February 16, 2025 12:54

[apache#6078] feat(core): Support model event to Gravitino server

98086ab

Support model event to Gravitino server. Add list, get, create and delete events to both model and model version.

[apache#6078] feat(core): Support model event to Gravitino server

c96ff02

Fix some class comments.

[apache#6078] feat(core): Support model event to Gravitino server

f83ca75

Fix some error.

[apache#6078] feat(core): Support model event to Gravitino server

8c67719

Fix some error and add ModelEventDispatcher to Gravitino server.

[apache#6220] improve(CLI): Clean up GravitinoCommandLine class now i…

16064f9

…t been refactored rename drop event and operation type.

[apache#6067] improvement(core): Support model pre event to Gravitino…

91493af

… server fix some issues.

[apache#6067] improvement(core): Support model pre event to Gravitino…

8d73819

… server Remove Model Event.

Abyss-lord force-pushed the model-pre-event branch from 6c00cd4 to 8d73819 Compare February 16, 2025 04:54

justinmclean assigned Abyss-lord Feb 24, 2025

FANNG1 reviewed Feb 24, 2025

View reviewed changes

FANNG1 reviewed Feb 26, 2025

View reviewed changes

core/src/main/java/org/apache/gravitino/listener/api/info/ModelInfo.java Outdated Show resolved Hide resolved

FANNG1 reviewed Feb 26, 2025

View reviewed changes

core/src/main/java/org/apache/gravitino/listener/api/info/ModelInfo.java Outdated Show resolved Hide resolved

FourFriends and others added 7 commits March 2, 2025 16:10

Abyss-lord and others added 17 commits March 2, 2025 16:10

[apache#6067] improvement(core): Support model pre event to Gravitino…

ca6e018

… server Fix some bugs.

Merge branch 'main' into model-pre-event

3644cb8

tengqm reviewed Mar 2, 2025

View reviewed changes

[apache#6067] improvement(core): Support model pre event to Gravitino…

7a1e02c

… server Fix some bugs.

Abyss-lord requested a review from FANNG1 March 3, 2025 01:30

Merge branch 'main' into model-pre-event

7f5b91a

tengqm reviewed Mar 3, 2025

View reviewed changes

FANNG1 reviewed Mar 3, 2025

View reviewed changes

[apache#6067] improvement(core): Support model pre event to Gravitino…

b419212

… server Fix some bugs.

Abyss-lord requested a review from FANNG1 March 3, 2025 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#6076] improve(CLI): Support model pre event to Gravitino server #6250

[#6076] improve(CLI): Support model pre event to Gravitino server #6250

Abyss-lord commented Jan 15, 2025 •

edited

Loading

Abyss-lord commented Jan 18, 2025

Abyss-lord commented Feb 19, 2025

FANNG1 commented Feb 24, 2025

tengqm commented Feb 25, 2025

FANNG1 commented Feb 25, 2025

tengqm commented Feb 25, 2025

FANNG1 commented Feb 26, 2025

tengqm Mar 2, 2025

tengqm Mar 2, 2025

Abyss-lord commented Mar 2, 2025

Abyss-lord commented Mar 3, 2025

Abyss-lord commented Mar 3, 2025

FANNG1 commented Mar 3, 2025

tengqm Mar 3, 2025

Abyss-lord commented Mar 3, 2025

[#6076] improve(CLI): Support model pre event to Gravitino server #6250

Are you sure you want to change the base?

[#6076] improve(CLI): Support model pre event to Gravitino server #6250

Conversation

Abyss-lord commented Jan 15, 2025 • edited Loading

What changes were proposed in this pull request?

PreEvent

ModelEventDispatcher

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Model Event

Model Version Event

Abyss-lord commented Jan 18, 2025

Abyss-lord commented Feb 19, 2025

FANNG1 commented Feb 24, 2025

tengqm commented Feb 25, 2025

FANNG1 commented Feb 25, 2025

tengqm commented Feb 25, 2025

FANNG1 commented Feb 26, 2025

tengqm Mar 2, 2025

Choose a reason for hiding this comment

tengqm Mar 2, 2025

Choose a reason for hiding this comment

Abyss-lord commented Mar 2, 2025

Abyss-lord commented Mar 3, 2025

Abyss-lord commented Mar 3, 2025

FANNG1 commented Mar 3, 2025

tengqm Mar 3, 2025

Choose a reason for hiding this comment

Abyss-lord commented Mar 3, 2025

Abyss-lord commented Jan 15, 2025 •

edited

Loading