Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-17205. Move personality file from Yetus to Hadoop repository #2226

Merged
merged 4 commits into from
Aug 18, 2020
Merged

HADOOP-17205. Move personality file from Yetus to Hadoop repository #2226

merged 4 commits into from
Aug 18, 2020

Conversation

sunchao
Copy link
Member

@sunchao sunchao commented Aug 14, 2020

Currently for CI build and testing we maintain personality scripts in both Apache Yetus and Apache Hadoop. This poses problem when one needs to change both places, for example HADOOP-17125.

This proposes to move the personality file into the Hadoop repo itself, so that we can manage them in a single place. The downside for this is we may need to duplicate the scripts in every branch.

@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/console in case of problems.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 28m 50s trunk passed
+1 💚 mvnsite 20m 16s trunk passed
+1 💚 shadedclient 14m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 19m 6s the patch passed
+1 💚 mvnsite 17m 10s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 shelldocs 0m 18s There were no new shelldocs issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 27s root in the patch passed.
+1 💚 asflicense 1m 4s The patch does not generate ASF License warnings.
137m 32s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/artifact/out/Dockerfile
GITHUB PR #2226
Optional Tests dupname asflicense shellcheck shelldocs mvnsite unit
uname Linux 4184b6cdd2b6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 86bbd38
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/testReport/
Max. process+thread count 450 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@sunchao sunchao requested a review from aajisaka August 14, 2020 16:34
@sunchao
Copy link
Member Author

sunchao commented Aug 14, 2020

@aajisaka : this adds personality file to the trunk. Once agreed on this I'll also add to other branches.

aajisaka
aajisaka reviewed Aug 17, 2020
View reviewed changes
dev-support/bin/hadoop.sh Outdated Show resolved Hide resolved
@aajisaka
Copy link
Member

In addition, I think we can revert apache/yetus#46 in Hadoop repository.

@sunchao
Copy link
Member Author

sunchao commented Aug 17, 2020

Thanks @aajisaka . Addressed your comments and re-triggering CI.

@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/console in case of problems.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 28m 47s trunk passed
+1 💚 mvnsite 20m 19s trunk passed
+1 💚 shadedclient 14m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 19m 9s the patch passed
+1 💚 mvnsite 17m 40s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 shelldocs 0m 18s There were no new shelldocs issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 0s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 46s root in the patch passed.
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
138m 26s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/artifact/out/Dockerfile
GITHUB PR #2226
Optional Tests dupname asflicense shellcheck shelldocs mvnsite unit
uname Linux c46257755145 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5092ea6
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/testReport/
Max. process+thread count 477 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka
aajisaka reviewed Aug 17, 2020
View reviewed changes
Jenkinsfile Show resolved Hide resolved
@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/console in case of problems.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 31m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 44m 13s trunk passed
+1 💚 mvnsite 20m 13s trunk passed
+1 💚 shadedclient 14m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 18m 58s the patch passed
+1 💚 mvnsite 17m 6s the patch passed
+1 💚 shellcheck 0m 1s There were no new shellcheck issues.
+1 💚 shelldocs 0m 18s There were no new shelldocs issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 7s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 0s root in the patch passed.
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
183m 6s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/artifact/out/Dockerfile
GITHUB PR #2226
Optional Tests dupname asflicense shellcheck shelldocs mvnsite unit
uname Linux 7cca94bd6377 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b367942
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka aajisaka self-requested a review August 18, 2020 03:04
aajisaka
aajisaka approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @sunchao

@aajisaka aajisaka merged commit fefacf2 into apache:trunk Aug 18, 2020
aajisaka pushed a commit that referenced this pull request Aug 18, 2020
@sunchao @aajisaka
HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…
197219a 
…2226)

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit fefacf2)
aajisaka pushed a commit that referenced this pull request Aug 18, 2020
@sunchao @aajisaka
HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…
5858c74 
…2226)

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit fefacf2)
aajisaka pushed a commit that referenced this pull request Aug 18, 2020
@sunchao @aajisaka
HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…
bd3817b 
…2226)

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit fefacf2)
aajisaka pushed a commit that referenced this pull request Aug 18, 2020
@sunchao @aajisaka
HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…
c7ab319 
…2226)

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit fefacf2)
aajisaka pushed a commit that referenced this pull request Aug 18, 2020
@sunchao @aajisaka
HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…
412f30d 
…2226)

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit fefacf2)
@sunchao sunchao mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunchao @hadoop-yetus @aajisaka