YETUS-816. Improve hadoop personality to support ozone/hdds projects #46
Conversation
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
| personality_enqueue_module ${module} ${extra} | ||
| OZONE_CHANGED=false | ||
| CORE_HADOOP_CHANGED=false | ||
| for module in $CHANGED_MODULES |
There was a problem hiding this comment.
CHANGED_MODULES is an array, not a string. You want "${CHANGED_MODULES[@]}" here. (Also, looks like a bug in shellcheck: it should have flagged that.)
There was a problem hiding this comment.
Thanks a lot, fixed.
(BTW, It was not flagged, I don't know why:
precommit/src/main/shell/personality/hadoop.sh:426:46: note: Double quote to prevent globbing and word splitting. [SC2086]
precommit/src/main/shell/personality/hadoop.sh:427:47: note: Double quote to prevent globbing and word splitting. [SC2086]
I tested with a simple shell script and similar structure was flagged there. I think the type of the CHANGED_MODULES is unknown here...)
| if [ "$CORE_HADOOP_CHANGED" = false ] && [ "$OZONE_CHANGED" = true ]; then | ||
| if [ "$testtype" != "mvnsite" ] && [ "$testtype" != "shadedclient" ]; then | ||
| personality_enqueue_module hadoop-hdds ${extra} | ||
| personality_enqueue_module hadoop-ozone ${extra} |
|
|
||
| if [ "$CORE_HADOOP_CHANGED" = false ] && [ "$OZONE_CHANGED" = true ]; then | ||
| if [ "$testtype" != "mvnsite" ] && [ "$testtype" != "shadedclient" ]; then | ||
| personality_enqueue_module hadoop-hdds ${extra} |
There was a problem hiding this comment.
shellcheck disable the message here. extra should have been an array but it wasn't when we first wrote yetus.
elek
changed the title
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thank you @aw-was-here the review and merge. I created a PR for hadoop to use the latest yetus which includes this change. apache/hadoop#599 |
Ozone/Hdds projects are not handled very well in the hadoop personality as in case of an ozone change all the hdds/ozone projects should be built and tested