Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built: Update revapi to 1.4.1 #8906

Closed
wants to merge 1 commit into from
Closed

Built: Update revapi to 1.4.1 #8906

wants to merge 1 commit into from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Oct 23, 2023

I don't think this is necessary since the API doesn't change between minor versions, but it is part of the release process :)

I don't think this is necessary since the API doesn't change
between minor versions, but it is part of the release process :)
@github-actions github-actions bot added the build label Oct 23, 2023
@jbonofre
Copy link
Member

FYI, related to revapi, I'm working on palantir/gradle-revapi#612.

@nastra
Copy link
Contributor

nastra commented Oct 23, 2023

I believe we typically don't update RevAPI to patch versions (at least we haven't done so for 1.2.1 or 1.3.1 in the past)

@ajantha-bhat
Copy link
Member

I believe we typically don't update RevAPI to patch versions (at least we haven't done so for 1.2.1 or 1.3.1 in the past)

It is because revAPI expects a tag from the main branch. For point release, the tags are not created from the main branch. Hence, revAPI doesn't work.
#6102 (comment)

@Fokko
Copy link
Contributor Author

Fokko commented Oct 25, 2023

@ajantha-bhat thanks for the context, closing this one

@Fokko Fokko closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants