-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-2051] Make ColumnarBatchSerializer supports relocation so that continuous shuffle block fetching can be enabled #2052
Conversation
Run Gluten Clickhouse CI |
acc088e
to
6ef2b73
Compare
Run Gluten Clickhouse CI |
@zhztheplayer @zhouyuan Can you please help review this? |
@WangGuangxin good finding! Curious how the performance gain look like? The marker is 4 bytes only if I i understand this correctly -yuan |
@zhouyuan Hi, the benefits are not comes from the 4bytes savings, but make the Spark AQE feature "batch fetch shuffle blocks" take effect. In short, when Spark AQE do coalesce partitions, it can fetch continuous blocks in batch, instead of fetch blocks one by one. But it has some preconditions, one is the serialization of shuffle must support the so called relocation https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala#L48C48-L48C85. Currently, the |
@WangGuangxin thanks for detailed explanation, got the idea now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@WangGuangxin @zhouyuan we have meet the same problem,if the pr is ready,can we merge it? |
6ef2b73
to
99ff551
Compare
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
6ececfe
to
fd0736b
Compare
Run Gluten Clickhouse CI |
…huffle block fetching can be enabled
fd0736b
to
4ebd167
Compare
Run Gluten Clickhouse CI |
Signed-off-by: Yuan Zhou <[email protected]>
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 works for me
What changes were proposed in this pull request?
Spark supports fetch the contiguous shuffle blocks in batch, which is enabled by default (by conf
spark.sql.adaptive.fetchShuffleBlocksInBatch
). This feature has a big performance improvement in our production.However, currently, since ColumnarBatchSerializer's
supportsRelocationOfSerializedObjects
return false, so that this feature cann't take effect.In fact, the arrow serialization does support reloation if we don't write schema (which is default to true) and don't write EOS (which is an optional in arrow rpc serialization format)
https://wesm.github.io/arrow-site-test/format/IPC.html#streaming-format

(Fixes: #2051)
How was this patch tested?
Manually test using our internal query