-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Fix JUnit reports check at the end of builds #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh well... I won't be able to test this on the PR CI. The CI on PRs breaks as soon as a test fails. We're going to need to trust my tests on my fork for this... |
Got an unexpected failure on my tests.. let me check that. |
tiagobento
force-pushed
the
fix-junit-reports-check
branch
from
February 16, 2023 17:31
d92e0a5
to
17946af
Compare
tomasdavidorg
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tiagobento
caponetto
approved these changes
Feb 17, 2023
Kusuma04-dev
added a commit
to Kusuma04-dev/incubator-kie-tools
that referenced
this pull request
Jan 7, 2025
Kusuma04-dev
added a commit
to Kusuma04-dev/incubator-kie-tools
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There are two tests failing on purpose. Let a build run with those, then I'll do a new commit.I tested several approaches with https://github.com/mikepenz/action-junit-report and https://github.com/dorny/test-reporter, but none worked. So I figured I should do a simple scrip that does what we want.
I ended up creating an issue on https://github.com/mikepenz/action-junit-report too.
See mikepenz/action-junit-report#794