Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix JUnit reports check at the end of builds #1466

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

tiagobento
Copy link
Contributor

@tiagobento tiagobento commented Feb 15, 2023

Note: There are two tests failing on purpose. Let a build run with those, then I'll do a new commit.

I tested several approaches with https://github.com/mikepenz/action-junit-report and https://github.com/dorny/test-reporter, but none worked. So I figured I should do a simple scrip that does what we want.

I ended up creating an issue on https://github.com/mikepenz/action-junit-report too.
See mikepenz/action-junit-report#794

@tiagobento
Copy link
Contributor Author

Oh well... I won't be able to test this on the PR CI. The CI on PRs breaks as soon as a test fails. We're going to need to trust my tests on my fork for this...

@tiagobento tiagobento temporarily deployed to ci February 15, 2023 20:48 — with GitHub Actions Inactive
@tiagobento tiagobento added the pr: DO NOT MERGE Draft PR, not ready for merging label Feb 15, 2023
@tiagobento tiagobento temporarily deployed to ci February 15, 2023 20:50 — with GitHub Actions Inactive
@tiagobento
Copy link
Contributor Author

Got an unexpected failure on my tests.. let me check that.

@tiagobento tiagobento force-pushed the fix-junit-reports-check branch from d92e0a5 to 17946af Compare February 16, 2023 17:31
@tiagobento tiagobento removed the pr: DO NOT MERGE Draft PR, not ready for merging label Feb 16, 2023
@tiagobento tiagobento temporarily deployed to ci February 16, 2023 17:32 — with GitHub Actions Inactive
@tiagobento tiagobento temporarily deployed to ci February 16, 2023 17:32 — with GitHub Actions Inactive
@tiagobento tiagobento temporarily deployed to ci February 16, 2023 17:32 — with GitHub Actions Inactive
Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tiagobento

@tiagobento tiagobento merged commit 16f65e1 into apache:main Feb 17, 2023
Kusuma04-dev added a commit to Kusuma04-dev/incubator-kie-tools that referenced this pull request Jan 7, 2025
Kusuma04-dev added a commit to Kusuma04-dev/incubator-kie-tools that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants