Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior with multiple report_paths and failures not being processed #794

Closed
tiagobento opened this issue Feb 14, 2023 · 4 comments · Fixed by #797
Closed

Weird behavior with multiple report_paths and failures not being processed #794

tiagobento opened this issue Feb 14, 2023 · 4 comments · Fixed by #797
Assignees

Comments

@tiagobento
Copy link

tiagobento commented Feb 14, 2023

Hi!

I'm seeing some weird behavior, where Process test results only prints test case names of the first glob I input to report_paths.
More than that, it looks like this actions is not correctly failing the job when there's a failure.

Here's my job that should've reported error at the "Check test results (main only)" step.
https://github.com/tiagobento/kie-tools/actions/runs/4177206528

There are failures on packages/**/dist-tests/junit-report*.xml and packages/**/dist-it-tests/junit-report*.xml, but only reports on packages/**/dist-it-tests/junit-report*.xml are being listed (because it's the first one on the report_paths configuration).

Please let me know if you need more details so I can help you find a solution!

Thanks!!

@mikepenz
Copy link
Owner

mikepenz commented Feb 16, 2023

Thank you very much for the report

@tiagobento would it be possible to rerun this build with Debug logs?

It would show if we iterate through the respective configurations: https://github.com/mikepenz/action-junit-report/blob/main/src/testParser.ts#L405

@mikepenz mikepenz self-assigned this Feb 16, 2023
@tiagobento
Copy link
Author

@mikepenz
Copy link
Owner

Thank you very much. That is very helpful. I'll give it a closer look the next days.

@mikepenz
Copy link
Owner

Opened a PR with a fix for this (based on the debug logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants