LUCENE-9349: TermInSetQuery should use consumeMatchingTerms in visit() #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also make FuzzyQuery's visit() method nicer if we switch back to not holding its automaton directly on the query. |
|
ok. +1 |
asfgit
pushed a commit
that referenced
this pull request
Apr 29, 2020
#1465) TermInSetQuery currently iterates through all its prefix-encoded terms in order to build an array to pass back to its visitor when visit() is called. This seems like a waste, particularly when the visitor is not actually consuming the terms (for example, when doing a clause-count check before executing a search). This commit changes TermInSetQuery to use consumeTermsMatching(), and also changes the signature of this method so that it takes a BytesRunAutomaton supplier to allow for lazy instantiation.
MarcusSorealheis
added a commit
to MarcusSorealheis/lucene-solr
that referenced
this pull request
Apr 30, 2020
* upstream/master: SOLR-14237: Fix HDFS nightly test failure LUCENE-9278: concatenate paths for sourcepath using path separator rather than whitespace (which causes invalid option to be passed to javadoc). LUCENE-9333: Add gradle task to compile changes.txt to a html (apache#1468) update CHANGES for apache#807 Fix tests to survive nightly runs with many documents SOLR-14173: Don't use JQuery-Slim as it breaks the sidebar sub-menu system. SOLR-14237: A new panel with security info in admin UI's dashboard SOLR-14237: A new panel with security info in admin UI's dashboard LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects SOLR-14173: Change left nav item highlighting to fix menu jumpiness when hovering/selecting LUCENE-9349: TermInSetQuery should use consumeMatchingTerms in visit() (apache#1465) LUCENE-9089: update FST usage example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TermInSetQuery currently iterates through all its prefix-encoded terms
in order to build an array to pass back to its visitor when visit() is called.
This seems like a waste, particularly when the visitor is not actually
consuming the terms (for example, when doing a clause-count check
before executing a search). This commit changes TermInSetQuery to use
consumeTermsMatching(), and also changes the signature of this method so
that it takes a BytesRunAutomaton supplier to allow for lazy instantiation. In
addition, IndexSearcher's clause count check wasn't counting leaves that
called consumeTermsMatching().