LUCENE-9333: Add gradle task to compile changes.txt to a html #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweiss
approved these changes
Apr 30, 2020
|
Thanks, I will merge it to upstream soon. |
MarcusSorealheis
added a commit
to MarcusSorealheis/lucene-solr
that referenced
this pull request
Apr 30, 2020
* upstream/master: SOLR-14237: Fix HDFS nightly test failure LUCENE-9278: concatenate paths for sourcepath using path separator rather than whitespace (which causes invalid option to be passed to javadoc). LUCENE-9333: Add gradle task to compile changes.txt to a html (apache#1468) update CHANGES for apache#807 Fix tests to survive nightly runs with many documents SOLR-14173: Don't use JQuery-Slim as it breaks the sidebar sub-menu system. SOLR-14237: A new panel with security info in admin UI's dashboard SOLR-14237: A new panel with security info in admin UI's dashboard LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects SOLR-14173: Change left nav item highlighting to fix menu jumpiness when hovering/selecting LUCENE-9349: TermInSetQuery should use consumeMatchingTerms in visit() (apache#1465) LUCENE-9089: update FST usage example
This was referenced Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds "documentation" gradle task (equivalent of ant's "documentation") and its sub task "changesToHtml" (equivalent of ant's "changes-to-html" that compiles CHANGES.txt into Changes.html).
The output directories are
lucene/build/documentation(for lucene) andsolr/build/documentation(for solr). Those are not used by ant; ant outputs docs intolucene/build/docsandsolr/build/docs."documentation" task is incomplete for now; please see the TODO comment.
Gradle command
or
Tests
I checked md5 hash for the compiled Changes.html to verify the gradle task generates exact same file as ant (when version property is set to
9.0.0).Note about RDF processing
Not fully sure, but there is no equivalent gradle task for
ant.xmlpropertiesas far as I know.We could remove the ant call by writing our custom XPath processor which will be built on groovy's XmlSluper. I didn't do so here but just cloned the original Ant task. To me it would be preferable to replace the DOAP RDF with a JSON (or simply a CSV) instead of adding another XML processing code, if we want to completely drop the ant convention. ?