-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add a contrib operator for dynamic reshape #15872
Conversation
@mxnet-label-bot add [pr-work-in-progress, Operator, ONNX] |
Hi @vandanavk. I see that these changes have to fix onnx model import error. Sorry for a stupid question. How can I use them? Or I have to wait before it gets reviewed? I stuck on this problem for two weeks. |
@mxnet-label-bot update [Operator, pr-awaiting-review] |
@junrushao1994 for review |
You might have to pull in changes from all the following PRs into your copy of mxnet, build and then try to convert. The PRs are #15872, #15993, #15995, #15996 |
@samskalicky Would you mind reviewing this PR since it's related to dynamic reshape? |
Thanks for this contribution @vandanavk! Sorry its been sitting so long without review. Theres a few things i dont understand, i left some comments. could you please clarify? |
thanks for the review @samskalicky. let me know if the responses make things a little more clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Left a few comments.
@samskalicky @apeforest Addressed all review comments so far |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
@zheng-da may be interested to take a look? |
Description
MXNet's reshape operator expects the shape to be a static tuple. In some models, the shape attribute is decided based on the output of the previous layer. Example, #10789. Adding support for allowing a tensor for the target shape in Reshape.
Based on #14393
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Dynamic reshape:
Comments
Forward pass takes the same time as the original reshape operator