Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ONNX import/export: Dynamic reshape #15996

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Aug 24, 2019

Description

This PR adds ONNX conversion for dynamic reshape that has been added in PR #15872. The operator conversion is being tested through the conversion of PyTorch model to MXNet through ONNX (testing import). And converting the resultant MXNet model back to ONNX (testing export).

Can be merged only after #15872, #15993, #15995

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • ONNX import/export dynamic shape
  • Changes required to make ONNX export of dynamic shapes possible
  • Tests to convert Pytorch->ONNX->MXNet->ONNX.

Comments

Fixes #13774
Fixes #13395
Fixes #13949
Fixes #14916

@vandanavk vandanavk requested a review from szha as a code owner August 24, 2019 20:10
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [pr-work-in-progress, ONNX]

@marcoabreu marcoabreu added ONNX pr-work-in-progress PR is still work in progress labels Aug 24, 2019
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot update [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
2 participants