Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsh_syscmds: update rptun_ping to rpmsg_ping, add cmd_rpmsg. #2270

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

wyr8899
Copy link

@wyr8899 wyr8899 commented Jan 26, 2024

Summary

To support rpmsg ioctl, add cmd_rpmsg function, and update rptun ping to rpmsg ping.
depends on apache/nuttx#11618

Impact

Able to use rpmsg ioctl cmd.

Testing

Tested in sim vela and 86 panel.

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a commit message

@acassis
Copy link
Contributor

acassis commented Jan 29, 2024

@xiaoxiang781216 why rptun and rpmsg commands are implemented as NSH commands? I think it should be just a regular command like "pppd" or other. Also although it is used for test under NSH, keeping it outside will be easier to use as standalone application.

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 why rptun and rpmsg commands are implemented as NSH commands?

Since rptun/rpmsg is a simple mapping to kernel rptun/rpmsg driver, just like cmd_losetup operate on /dev/loop.

I think it should be just a regular command like "pppd" or other.

Yes, it could be move to apps/system, but it belong another task.

Also although it is used for test under NSH, keeping it outside will be easier to use as standalone application.

Since the action of rptun/rpmsg command is very simple:

  1. Parse command line argument
  2. Open the node under /dev/ and call ioctl

If the user disables nsh, it's simpler to call ioctl directly, instead launch the standalone application.

To support rpmsg ioctl, add cmd_rpmsg function, and update rptun ping to rpmsg ping.
depends on apache/nuttx#11618

Signed-off-by: wangyongrong <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 32f269a into apache:master Jan 31, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants