It should be possible to use ping without rptun being enabled, so striped rptun_ping out of rptun and rename to rpmsg_ping. #11618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Jan 29, 2024
anchao
reviewed
Jan 29, 2024
wyr8899
force-pushed
the
rptun_ping
branch
2 times, most recently
from
1a6d424 to
5217a13
Compare
raiden00pl
approved these changes
Jan 29, 2024
|
In order to ensure that CI passes, definitions such as RPTUNIOC_START are temporarily retained. |
wyr8899
pushed a commit
to wyr8899/nuttx-apps
that referenced
this pull request
Jan 30, 2024
To support rpmsg ioctl, add cmd_rpmsg function, and update rptun ping to rpmsg ping. depends on apache/nuttx#11618 Signed-off-by: wangyongrong <[email protected]>
jerpelea
approved these changes
Jan 30, 2024
It should be possible to use ping without rptun being enabled, so striped rptun_ping out of rptun and rename to rpmsg_ping. Signed-off-by: wangyongrong <[email protected]>
Signed-off-by: wangyongrong <[email protected]>
xiaoxiang781216
approved these changes
Jan 30, 2024
wyr8899
pushed a commit
to wyr8899/nuttx-apps
that referenced
this pull request
Jan 31, 2024
To support rpmsg ioctl, add cmd_rpmsg function, and update rptun ping to rpmsg ping. depends on apache/nuttx#11618 Signed-off-by: wangyongrong <[email protected]>
xiaoxiang781216
pushed a commit
to apache/nuttx-apps
that referenced
this pull request
Jan 31, 2024
To support rpmsg ioctl, add cmd_rpmsg function, and update rptun ping to rpmsg ping. depends on apache/nuttx#11618 Signed-off-by: wangyongrong <[email protected]>
mlyszczek
pushed a commit
to mlyszczek/incubator-nuttx-apps
that referenced
this pull request
Feb 27, 2024
To support rpmsg ioctl, add cmd_rpmsg function, and update rptun ping to rpmsg ping. depends on apache/nuttx#11618 Signed-off-by: wangyongrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It should be possible to use ping without rptun being enabled., so striped rptun_ping out of rptun and rename to rpmsg_ping.
need be merged together with apache/nuttx-apps#2270
Impact
Ping can also be used without rptun enabled.
Testing
Tested in sim vela and 86panel.