system/cu: remove canonical input mode from termios flag #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASCII_DEL will unable to handle after below change: apache/nuttx#14037 | commit df5c876932c4c82e8aee32adca651bb99d9d6200 | Author: zhangwenjian <[email protected]> | Date: Thu May 23 13:13:48 2024 +0800 | | libc:getline support backspace | | Signed-off-by: zhangwenjian <[email protected]> remove canonical input mode to support backspace in cu Signed-off-by: chao an <[email protected]>
$ ../nuttx/tools/checkpatch.sh -g HEAD~1 apps/system/cu/cu_main.c:5:78: error: Long line found Signed-off-by: chao an <[email protected]>
xiaoxiang781216
approved these changes
Jan 22, 2025
cederom
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
system/cu: remove canonical input mode from termios flag.ASCII_DELstopped working after below change:Getline support backspace nuttx#14037
cu.Signed-off-by: chao an [email protected]
Impact
CU: Backspace works again on cu / nsh console.
Testing
sim/rpproxy sim/rpserver cu and check the backspace whether works as expected.