-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getline support backspace #14037
Getline support backspace #14037
Conversation
Signed-off-by: zhangwenjian <[email protected]>
Signed-off-by: zhangwenjian <[email protected]>
Signed-off-by: zhangwenjian <[email protected]>
[Experimental Bot, please feedback here] This PR does not meet the NuttX requirements. Here's why and how to improve it:
Example of an Improved Summary: This PR addresses [Issue #] by adding backspace support to the |
@xiaoxiang781216 @zhangwenjian111 Assuming my git bisect attempt was correct, this PR has broken the backspace on my setup (custom board, UART console, MiniCom terminal on via WSL on Windows 11) is no longer working and I can no longer delete characters. Is there some other setting (or change of a setting) that is related to this? |
do you update nsh too? apache/nuttx-apps#2664 |
HOWEVER - perhaps this PR could have mentioned in the IMPACT section that nsh would be broken without updating to the latest nuttx-apps? |
update, thanks. |
ASCII_DEL will unable to handle after below change: apache/nuttx#14037 | commit df5c876932c4c82e8aee32adca651bb99d9d6200 | Author: zhangwenjian <[email protected]> | Date: Thu May 23 13:13:48 2024 +0800 | | libc:getline support backspace | | Signed-off-by: zhangwenjian <[email protected]> remove canonical input mode to support backspace in cu Signed-off-by: chao an <[email protected]>
@xiaoxiang781216 @zhangwenjian111 regression on cu command, here is fix: |
ASCII_DEL will unable to handle after below change: apache/nuttx#14037 | commit df5c876932c4c82e8aee32adca651bb99d9d6200 | Author: zhangwenjian <[email protected]> | Date: Thu May 23 13:13:48 2024 +0800 | | libc:getline support backspace | | Signed-off-by: zhangwenjian <[email protected]> remove canonical input mode to support backspace in cu Signed-off-by: chao an <[email protected]>
Summary
getline function support backspace, need work with apache/nuttx-apps#2664
Impact
None
Testing
sim,qemu,arm64