-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpio: use small lock to protect configgpio #15219
Conversation
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details. Here's a breakdown of what's missing:
In short, the PR needs substantially more detail to be acceptable. It should clearly articulate the motivation, implementation, and impact of the change, along with thorough testing evidence. |
reason: We would like to replace the critical section with a small lock. Signed-off-by: hujun5 <[email protected]>
Emm ... Do you think this code works properly? |
fix regression from apache#15219 Signed-off-by: hujun5 <[email protected]>
I missed some replacements. #15238 |
fix regression from #15219 Signed-off-by: hujun5 <[email protected]>
Sorry @hujun260 wonder if we missed out something for Tiva Spin Lock?
More Tiva Spin Lock errors at NuttX Dashboard: |
|
fix regression from apache#15219 Signed-off-by: hujun5 <[email protected]>
fix regression from #15219 Signed-off-by: hujun5 <[email protected]>
fix regression from apache#15219 Signed-off-by: hujun5 <[email protected]>
Summary
gpio: use small lock to protect configgpio
reason:
We would like to replace the critical section with a small lock.
Impact
gpio
Testing
ci