chore: manage deps with maturin (#1611)

* chore: manage deps with maturin Signed-off-by: Chojan Shang <[email protected]> * chore(ci): try to make the workflow work Signed-off-by: Chojan Shang <[email protected]> * ci: build with pip and maturin Signed-off-by: Chojan Shang <[email protected]> --------- Signed-off-by: Chojan Shang <[email protected]>
apache · Mar 15, 2023 · 8f2ffa8 · 8f2ffa8
1 parent a2db495
commit 8f2ffa8
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 19 deletions.
diff --git a/.github/workflows/bindings_python.yml b/.github/workflows/bindings_python.yml
@@ -47,18 +47,13 @@ jobs:
         with:
           python-version: '3.11'
       - uses: Swatinem/rust-cache@v2
-      - uses: PyO3/maturin-action@v1
-        with:
-          manylinux: off
-          working-directory: "bindings/python"
-          command: build
-          args: --release --sdist -o dist
+      - name: Build with maturin
+        working-directory: "bindings/python"
+        run: |
+          python -m pip install -e .[test]
       - name: Run pytest
         working-directory: "bindings/python"
         run: |
-          set -e
-          python -m pip install dist/opendal-*.whl
-          python -m pip install -r test_requirements.txt
           python -m pytest
 
   linux:

diff --git a/bindings/python/README.md b/bindings/python/README.md
@@ -34,16 +34,10 @@ asyncio.run(main())
 
 ## Development
 
-Install `maturin`:
-
-```shell
-pip install maturin
-```
-
 Setup virtualenv:
 
 ```shell
-virtualenv venv
+python -m venv venv
 ```
 
 Activate venv:
@@ -52,6 +46,12 @@ Activate venv:
 source venv/bin/activate
 ````
 
+Install `maturin`:
+
+```shell
+pip install maturin[patchelf]
+```
+
 Build bindings:
 
 ```shell
@@ -61,6 +61,6 @@ maturin develop
 Running some tests:
 
 ```shell
-pip install -r test_requirements.txt
+maturin develop -E test
 pytest
 ```
diff --git a/bindings/python/pyproject.toml b/bindings/python/pyproject.toml
@@ -31,6 +31,9 @@ name = "opendal"
 readme = "README.md"
 requires-python = ">=3.7"
 
+[project.optional-dependencies]
+test = ["pytest", "pytest-asyncio"]
+
 [project.urls]
 Documentation = "https://docs.rs/opendal/"
 Homepage = "https://opendal.databend.rs/"

diff --git a/bindings/python/test_requirements.txt b/bindings/python/test_requirements.txt