Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manage deps with maturin #1611

Merged
merged 3 commits into from
Mar 15, 2023
Merged

chore: manage deps with maturin #1611

merged 3 commits into from
Mar 15, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Mar 15, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

I don't think we need to maintain *-requirements.txt. pyproject.toml is powerful.

@PsiACE PsiACE marked this pull request as draft March 15, 2023 09:37
@Xuanwo
Copy link
Member

Xuanwo commented Mar 15, 2023

Seems cool, please also update the workflow~

@PsiACE PsiACE marked this pull request as ready for review March 15, 2023 10:24
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are welcome to merge it on your own.

@PsiACE PsiACE merged commit 8f2ffa8 into apache:main Mar 15, 2023
@PsiACE PsiACE deleted the pyproject branch March 15, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants