Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/gcs): checked_rem_euclid could return Some(0) #2220

Merged
merged 2 commits into from
May 6, 2023
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 6, 2023

No description provided.

@Xuanwo Xuanwo changed the title fix: checked_rem_euclid could return Some(0) fix(services/gcs): checked_rem_euclid could return Some(0) May 6, 2023
@Xuanwo Xuanwo marked this pull request as ready for review May 6, 2023 16:54
@Xuanwo Xuanwo requested review from PsiACE, ClSlaid and sundy-li as code owners May 6, 2023 16:54
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo merged commit 30e82f5 into main May 6, 2023
@Xuanwo Xuanwo deleted the fix-gcs branch May 6, 2023 17:00
suyanhanx pushed a commit to suyanhanx/opendal that referenced this pull request May 8, 2023
* fix: checked_rem_euclid could return Some(0)

Signed-off-by: Xuanwo <[email protected]>

* Add error context

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants