fix(services/gcs): checked_rem_euclid could return Some(0) (apache#2220)

* fix: checked_rem_euclid could return Some(0) Signed-off-by: Xuanwo <[email protected]> * Add error context Signed-off-by: Xuanwo <[email protected]> --------- Signed-off-by: Xuanwo <[email protected]>
suyanhanx · May 8, 2023 · 36bb249 · 36bb249
1 parent 9543da2
commit 36bb249
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/src/services/gcs/backend.rs b/core/src/services/gcs/backend.rs
@@ -351,12 +351,14 @@ impl Builder for GcsBuilder {
         let signer = GoogleSigner::new("storage");
 
         let write_fixed_size = self.write_fixed_size.unwrap_or(DEFAULT_WRITE_FIXED_SIZE);
-        if write_fixed_size.checked_rem_euclid(256 * 1024).is_some() {
+        // GCS requires write must align with 256 KiB.
+        if write_fixed_size % (256 * 1024) != 0 {
             return Err(Error::new(
                 ErrorKind::ConfigInvalid,
                 "The write fixed buffer size is misconfigured",
             )
-            .with_context("service", Scheme::Gcs));
+            .with_context("service", Scheme::Gcs)
+            .with_context("write_fixed_size", write_fixed_size.to_string()));
         }
 
         let backend = GcsBackend {